Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vue): vetur support #22403

Merged
merged 12 commits into from Nov 6, 2020
Merged

feat(vue): vetur support #22403

merged 12 commits into from Nov 6, 2020

Conversation

liamdebeasi
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Currently, IDEs that support Vetur do not show code hints for Ionic Vue components.

What is the new behavior?

  • Added Vetur support for Ionic component tags, attributes, and possible attribute values.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: vue @ionic/vue package label Oct 29, 2020
@liamdebeasi liamdebeasi added this to the 5.5.0 milestone Nov 4, 2020
@liamdebeasi liamdebeasi merged commit e76f79d into master Nov 6, 2020
@liamdebeasi liamdebeasi deleted the vue-vetur branch November 6, 2020 19:25
TakumaKira pushed a commit to TakumaKira/ionic-framework that referenced this pull request Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant