Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(vue): improved lifecycle methods #22241

Merged
merged 11 commits into from Nov 10, 2020
Merged

feat(vue): improved lifecycle methods #22241

merged 11 commits into from Nov 10, 2020

Conversation

michaeltintiuc
Copy link
Contributor

  • Improve tooling by adding component options for lifecycle events, this allows for code completion and hinting.
  • Make fireLifecycle function's lifecycle argument stricter, limiting it to known lifecycle events
  • Reuse @ionic/core lifecycle exports

@liamdebeasi liamdebeasi changed the base branch from ionic-vue to master October 8, 2020 17:45
@github-actions github-actions bot added the package: vue @ionic/vue package label Oct 11, 2020
@michaeltintiuc michaeltintiuc mentioned this pull request Oct 17, 2020
Merged
@liamdebeasi liamdebeasi changed the title [Vue] Lifecycle events tooling feat(vue): improved lifecycle methods Nov 5, 2020
@liamdebeasi liamdebeasi merged commit f5b0299 into ionic-team:master Nov 10, 2020
@liamdebeasi liamdebeasi mentioned this pull request Nov 10, 2020
Closed
TakumaKira pushed a commit to TakumaKira/ionic-framework that referenced this pull request Nov 13, 2020
@michaeltintiuc
feat(vue): composition api lifecycle methods (ionic-team#22241)
cb9296e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: vue @ionic/vue package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michaeltintiuc @liamdebeasi