feat(segment): add swipeGesture property to allow for disabling of the swipe gesture

[TakumaKira]

closes #22048

Pull request checklist

Please check if your PR fulfills the following requirements:

• Tests for the changes have been added (for bug fixes / features)
• Docs have been reviewed and added / updated if needed (for bug fixes / features)
• Build (npm run build) was run locally and any changes were pushed
• Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes
• Other (please describe):

What is the current behavior?

Issue Number: #22048

What is the new behavior?

• By setting changeOnSwipe property to false, developers can disable to select ionSegmentButton inside on swiping/dragging.

Does this introduce a breaking change?

• Yes
• No

Other information

[brandyscarney]

Could we call this swipeGesture to match the naming of ion-menu and ion-nav?

<ion-menu swipeGesture="false" contentId="nav"> </ion-menu>

[brandyscarney]

Thank you for this by the way! The code looks good on initial review. Requested myself and Liam to test it. 🙂

[liamdebeasi]

A few small changes, but otherwise this looks really good. Nice job!

[liamdebeasi]

One small test change, then I think we are good to merge!

[liamdebeasi]

This looks great, thanks for taking care of this!

[liamdebeasi]

@TakumaKira One last thing -- can you sync this branch with the latest master? We had a few build issue with node 15/npm 7 that have since been resolved, but you will need to grab the latest from master to get the fixes.

[TakumaKira]

@liamdebeasi

@TakumaKira One last thing -- can you sync this branch with the latest master? We had a few build issue with node 15/npm 7 that have since been resolved, but you will need to grab the latest from master to get the fixes.

I think I'm done ;) I rebased the branch on the current master(commit d77a9d5).

[liamdebeasi]

Merged. Thank you!

[ZaLiTHkA]

I just had to apply the hacky workaround as posted in this comment on #22161 (which led me to #22048, which led me here), but I had to do this in a current app with @ionic/angular@6.1.1 and @angular/core@13.3.3.. has this issue perhaps returned in recent builds?

one intersting observation though: the "segment selection change on page scroll" issue only appears to happen on ion-segment elements that do have scrollable enabled. I'm not sure if this was a requirement of the original problem.. so could the behaviour I'm seeing here be caused by something else instead?