feat(chip): add disabled property #20658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ionic Latest
ionitron-bot
bot
added
package: angular
liamdebeasi
suggested changes
Mar 20, 2020
There was a problem hiding this comment.
Looks great! Can you just add a few tests in src/components/chip/test/states.index.html?
Something like:
<h3>Disabled</h3>
<p>
<ion-chip disabled>
<ion-label>Disabled</ion-label>
</ion-chip>
<ion-chip outline color="danger" class="ion-focused" disabled>
<ion-label>Disabled Outline</ion-label>
</ion-chip>
<ion-chip color="secondary" class="ion-focused" disabled>
<ion-icon name="checkmark-circle"></ion-icon>
<ion-label>Disabled Secondary with Icon</ion-label>
</ion-chip>
<ion-chip outline class="ion-focused" disabled>
<ion-icon name="git-pull-request"></ion-icon>
<ion-label>Disabled Outline with Icon and Avatar</ion-label>
<ion-icon name="close-circle"></ion-icon>
</ion-chip>
</p>
liamdebeasi
changed the title
disabled added
|
Yeah of course: Requested Changes are added. I didn't found the Opacity in the MD Spec (and i still don't 😂), but adjusted to 0.4. |
|
Thanks! Can you fix the failing build and merge conflicts? |
Merge latest master
# Conflicts: # angular/src/directives/proxies.ts # core/src/components.d.ts
|
Done 😇 |
|
Also add CSS Shadow Parts to this component. |
|
@shyamal890 |
13 tasks
liamdebeasi
approved these changes
Oct 22, 2020
liamdebeasi
previously requested changes
Nov 3, 2020
brandyscarney
approved these changes
Nov 3, 2020
Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
|
Merged. Thank you! |
Closed
TakumaKira
pushed a commit
to TakumaKira/ionic-framework
that referenced
this pull request
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #19510
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #19510
What is the new behavior?
Does this introduce a breaking change?