Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disabled chip #19510

Closed
simonhaenisch opened this issue Oct 1, 2019 · 6 comments · Fixed by #20658
Closed

feat: disabled chip #19510

simonhaenisch opened this issue Oct 1, 2019 · 6 comments · Fixed by #20658
Labels
help wanted a good issue for the community package: core @ionic/core package type: feature request a new feature, enhancement, or improvement

Comments

@simonhaenisch
Copy link
Contributor

simonhaenisch commented Oct 1, 2019

Feature Request

Ionic version:

[x] 4.x

Describe the Feature Request

Make it possible to disable chips.

Describe Preferred Solution

Add a disabled prop that disables the :hover styles (background-color, cursor, ...) and ripple.

Related Code

https://codepen.io/simonhaenisch/pen/bGbPzOm

Additional Context

https://material.io/components/chips/ has examples for disabled chips in various categories.

@ionitron-bot ionitron-bot bot added the triage label Oct 1, 2019
@liamdebeasi liamdebeasi added package: core @ionic/core package type: feature request a new feature, enhancement, or improvement labels Oct 1, 2019
@ionitron-bot ionitron-bot bot removed the triage label Oct 1, 2019
@brandyscarney brandyscarney added the help wanted a good issue for the community label Oct 8, 2019
@ionitron-bot
Copy link

ionitron-bot bot commented Oct 8, 2019

This issue has been labeled as help wanted. This label is added to issues that we believe would be good for contributors.

If you'd like to work on this issue, please comment here letting us know that you would like to submit a pull request for it. This helps us to keep track of the pull request and make sure there isn't duplicated effort.

For a guide on how to create a pull request and test this project locally to see your changes, see our contributing documentation.

Thank you!

@br1ghtt
Copy link

br1ghtt commented Nov 22, 2019

Working on a pull request.
In my opinion a chip in disabled state should have the following behavior:
A disbaled chip is not activatable, has a different alpha channel for the background, text and outline. It also has no hover effect and cursor.

@simonhaenisch
Copy link
Contributor Author

simonhaenisch commented Nov 22, 2019

@br1ghtt did you see the https://material.io/components/chips/ link? There's examples of the disabled chips and what they should look/behave like.

@Yohandah
Copy link

I am in need of this as well.

I am putting a "remove" icon into a chip and I want just the icon to have a button behavior, not the whole chip (ripple, cursor).

<ion-chip>
  <ion-label>text</ion-label>
  <!-- I just want this icon to be "clickable", not the whole chip -->
  <ion-icon name="close" (click)="someFunction()"></ion-icon>
</ion-chip>

Something I don't understand as well is that in the Ionic example when clicking a chip there is no ripple effect (https://ionicframework.com/docs/api/chip), but creating a new fresh project and adding a default ion-chip will have the behavior.

@liamdebeasi
Copy link
Contributor

Thanks for the issue. This has been resolved via #20658, and the feature will be available in an upcoming release of Ionic Framework.

TakumaKira pushed a commit to TakumaKira/ionic-framework that referenced this issue Nov 13, 2020
@ionitron-bot
Copy link

ionitron-bot bot commented Dec 5, 2020

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Dec 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted a good issue for the community package: core @ionic/core package type: feature request a new feature, enhancement, or improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants