[4.1.1] Ion-checkbox's internal button does not have an accessible name

[shreeshbhat]

Bug Report

Ionic version:
[x] 4.1.1

Current behavior:
Ion-checkbox's button does not have an accessible name.

Expected behavior:
Ion-checkbox should allow a prop named aria-label and set it on Ion-checkbox's internal button.

Steps to reproduce:
Use Ion-checkbox in a simple html and run Lighthouse Audit from Chrome.
It shows the following error for accessibility :

1. Buttons do not have an accessible name
   When a button doesn't have an accessible name, screen readers announce it as "button", making it unusable for users who rely on screen readers.

Failing Elements
<button type="button"></button>

Ionic info:

Ionic:

   ionic (Ionic CLI) : 4.3.1

System:

   NodeJS : v8.12.0
   npm    : 6.9.0
   OS     : macOS Sierra

[shreeshbhat]

I would like to pick this up as this is a beginner friendly fix.
To fix this, I will add a Prop named aria-label in ion-checkbox and assign it to the button used in the component.
Also, I can default it to name prop.
The changes are similar to how it is handled in ion-icon.
https://github.com/ionic-team/ionic/blob/4.1.x/core/src/components/icon/readme.md
If this approach sounds good, I will make the change and raise a PR this weekend.

[shawnm0705]

Same as <ion-select> the internal button generated from ion-select also doesn't have aria-label

[ionitron-bot]

This issue has been labeled as help wanted. This label is added to issues that we believe would be good for contributors.

If you'd like to work on this issue, please comment here letting us know that you would like to submit a pull request for it. This helps us to keep track of the pull request and make sure there isn't duplicated effort.

For a guide on how to create a pull request and test this project locally to see your changes, see our contributing documentation.

Thank you!

[ionitron-bot]

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.