Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(approov-advanced-http) add wrapper for approov advanced http cordova plugin #3682

Merged
merged 2 commits into from Aug 2, 2021

Conversation

Shivang8941
Copy link
Contributor

No description provided.

Copy link
Owner

@danielsogl danielsogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to rename the class name to something like ApproovHttp because there is already a Http plugin

@Shivang8941 Shivang8941 reopened this Jun 21, 2021
@Shivang8941
Copy link
Contributor Author

You have to rename the class name to something like ApproovHttp because there is already a Http plugin

We want to extend the same plugin that's why we've kept the same name. This way, it will be easier for existing users to migrate to this plugin without a major refactor.

@danielsogl
Copy link
Owner

@Shivang8941 I can understand your point but we dont accept duplicated plugin names. It is also recommended to switch to capacitor and its plugins to handle Http requests etc.

@Shivang8941
Copy link
Contributor Author

Shivang8941 commented Jun 29, 2021

@Shivang8941 I can understand your point but we dont accept duplicated plugin names. It is also recommended to switch to capacitor and its plugins to handle Http requests etc.

@danielsogl For time-being can we only update the plugin name? Will that suffice?

@Shivang8941
Copy link
Contributor Author

@danielsogl Can you please have a look at this again. I've updated the package name.

@danielsogl danielsogl merged commit b206b42 into danielsogl:master Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants