Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ble): update with setPin to allow set device pin #3652

Merged
merged 1 commit into from May 11, 2021

Conversation

itsLucario
Copy link
Contributor

Fixes: #3620

This PR will add the function which allow to set the device pin.
Set device pin is supported in latest version of "don/cordova-plugin-ble-central".

ble.setPin(pin, [success], [failure]);

https://github.com/don/cordova-plugin-ble-central#setpin

@Prabhu230818
Copy link

Hi how to write the setPin?? i'm add to latest version of cordova-plugin-ble-central
this.ble.setPin(pin).subscribe(success => {
console.log(success);
},
failure => {
console.log('failure');
});
This one show to error - Property 'setPin' does not exist on type 'BLE'.ts(2339)
issue1

@itsLucario
Copy link
Contributor Author

Hi @Prabhu230818,
This PR resolves the issue once it gets merged.
In mean while you can use my fork, build in local and use the plugin wrapper.

@itsLucario
Copy link
Contributor Author

@danielsogl Kindly review.

@danielsogl danielsogl self-assigned this May 11, 2021
@danielsogl danielsogl added the target: patch This PR is targeted for the next patch release label May 11, 2021
@danielsogl danielsogl merged commit da4ce96 into danielsogl:master May 11, 2021
@itsLucario itsLucario deleted the ble-update branch May 11, 2021 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"setPin" method is missing in wrapper for "cordova-plugin-ble-central" plugin.
3 participants