Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

content: Swiperjs event names should be prefixed with "swiper" in Angular migration guide #3306

Open
karocksjoelee opened this issue Dec 9, 2023 · 2 comments
Open

content: Swiperjs event names should be prefixed with "swiper" in Angular migration guide #3306

karocksjoelee opened this issue Dec 9, 2023 · 2 comments
Labels
content Issues related to the contents of the documentation website

Comments

@karocksjoelee
Copy link

URL

https://ionicframework.com/docs/angular/slides#events

Issue Description

The table : Below is a full list of method changes when going from ion-slides to Swiper Element:
is not corrrect , according to Swiperjs Events, it should have prefix of swiper

#All Swiper events are available as native DOM events but with lowercase names and swiper prefix (configurable via events-prefix parameter). E.g. slideChange becomes swiperslidechange.
@karocksjoelee karocksjoelee added the triage New issues label Dec 9, 2023
@amandaejohnston amandaejohnston self-assigned this Dec 11, 2023
@amandaejohnston
Copy link
Contributor

Thank you for the issue. I confirmed that the prefixed events should indeed be used even in an Angular app (i.e. without using addEventListener directly), at least on the latest version of Swiper. We'll want to update both the Angular docs page, and the migration example app linked at the bottom of the page: https://github.com/ionic-team/slides-migration-samples/tree/swiper/angular

@amandaejohnston amandaejohnston changed the title content: Swiperjs event not correct matched content: Swiperjs event names should be prefixed with "swiper" in Angular migration guide Dec 11, 2023
@amandaejohnston amandaejohnston added the content Issues related to the contents of the documentation website label Dec 11, 2023
@ionitron-bot ionitron-bot bot removed the triage New issues label Dec 11, 2023
@amandaejohnston amandaejohnston removed their assignment Dec 11, 2023
@karocksjoelee
Copy link
Author

Glad to help : )

@amandaejohnston amandaejohnston mentioned this issue Jan 2, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
content Issues related to the contents of the documentation website
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@karocksjoelee @amandaejohnston