Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ja): reflect translation of core.json #3096

Open
rdlabo opened this issue Aug 24, 2023 · 0 comments
Open

feat(ja): reflect translation of core.json #3096

rdlabo opened this issue Aug 24, 2023 · 0 comments
Labels
triage New issues

Comments

@rdlabo
Copy link
Collaborator

rdlabo commented Aug 24, 2023

Describe Problem

The translation/jp branch also translates core.json, and the preview screen shows the translated version. But https://ionicframework.com/docs/ja/ shows untranslated ones.

スクリーンショット 2023-08-24 午前11 33 28

スクリーンショット 2023-08-24 午前11 33 43

Describe Preferred Solution

In plugins/docusaurus-plugin-ionic-component-api/index.js , changes in translation/jp should be reflected when displayed at https://ionicframework.com/docs/ja/.

main branch:
https://github.com/ionic-team/ionic-docs/blob/main/plugins/docusaurus-plugin-ionic-component-api/index.js#L22

translation/jp branch
https://github.com/ionic-team/ionic-docs/blob/translation/jp/plugins/docusaurus-plugin-ionic-component-api/index.js#L23

Describe Alternatives

No response

Additional Information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage New issues
Projects
None yet
Development

No branches or pull requests

1 participant