Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Make setting the global CookieManager configurable #7340

Open
1 of 3 tasks
hbordersTwitch opened this issue Mar 13, 2024 · 0 comments
Open
1 of 3 tasks

[Feature]: Make setting the global CookieManager configurable #7340

hbordersTwitch opened this issue Mar 13, 2024 · 0 comments
Labels

Comments

@hbordersTwitch
Copy link

Description

CapacitorCookies always calls CookieHandler.setDefault with the Bridge's CookieManager. Make this configurable

Platforms

  • iOS
  • Android
  • Web

Request or proposed solution

If an app wants to use multiple instances of BridgeFragment, the newest instance will overwrite the global CookieManager defined with CookieHandler.setDefault(CookieManager), which will break global cookie handling for older instances. This is likely not a big problem if apps are using OkHttp or other frameworks that don't use the global CookieManager. Still, it would be good to make this behavior explicit.

Alternatives

Don't use the global CookieManager (available via CookieHandler.getDefault()) in any of your application code

Additional Information

Thanks so much for this project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant