From d397a7ff32a32cc0ba2e397c2f66bfd268ad8a04 Mon Sep 17 00:00:00 2001 From: Ioannis Canellos Date: Thu, 12 Nov 2020 17:13:01 +0200 Subject: [PATCH] fix(#2596) Add buildable ref for container, port and volume --- CHANGELOG.md | 1 + .../main/java/io/fabric8/kubernetes/ModelAnnotator.java | 7 +++++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7f6403b03d1..758c4a77c56 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -17,6 +17,7 @@ * Fix #2537: Checking for Readiness of DeploymentConfig * Fix #2300: Remove job extensions/v1beta1 from backward compatibiliy interceptor * Fix #2514: SharedIndexInformer watches only pods of its own namespace when run in the cluster +* Fix #2596: Add buildable references for Container, Port and Volume #### Improvements * Fix #2507: Add a test for creating a Job with generateName diff --git a/model-annotator/src/main/java/io/fabric8/kubernetes/ModelAnnotator.java b/model-annotator/src/main/java/io/fabric8/kubernetes/ModelAnnotator.java index 54d4c76f8e9..119504efada 100755 --- a/model-annotator/src/main/java/io/fabric8/kubernetes/ModelAnnotator.java +++ b/model-annotator/src/main/java/io/fabric8/kubernetes/ModelAnnotator.java @@ -63,8 +63,11 @@ public void propertyOrder(JDefinedClass clazz, JsonNode propertiesNode) { .param("prefix", "Doneable") .param("value", "done"); - buildable.paramArray("refs").annotate(BuildableReference.class) - .param("value", new JCodeModel()._class("io.fabric8.kubernetes.api.model.ObjectMeta")); + buildable.paramArray("refs") + .annotate(BuildableReference.class).param("value", new JCodeModel()._class("io.fabric8.kubernetes.api.model.ObjectMeta")) + .annotate(BuildableReference.class).param("value", new JCodeModel()._class("io.fabric8.kubernetes.api.model.Container")) + .annotate(BuildableReference.class).param("value", new JCodeModel()._class("io.fabric8.kubernetes.api.model.Port")) + .annotate(BuildableReference.class).param("value", new JCodeModel()._class("io.fabric8.kubernetes.api.model.Volume")); if (isCRD(clazz, propertiesNode) || isCRDList(clazz, propertiesNode)) { // add CRD-specific annotations String apiVersion = getApiVersion(propertiesNode);