Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix anonymous ptr to struct inlining #47

Merged
merged 2 commits into from Sep 23, 2022

Conversation

paulcacheux
Copy link
Contributor

@paulcacheux paulcacheux commented Sep 16, 2022

As can be shown in https://go.dev/play/p/4qEwn5yKzFj, JSON marshal rules also inline anonymous pointer to struct.

This PR implements this feature and adds a test for this.

@paulcacheux
Copy link
Contributor Author

@samlown can you take a look at this ? Thanks !

Copy link
Contributor

@samlown samlown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the tests are failing...

@paulcacheux
Copy link
Contributor Author

paulcacheux commented Sep 23, 2022

Oh yes it's because Pointer is only available on recent go versions, I fixed this in the latest commit

Copy link
Contributor

@samlown samlown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool thanks!

@samlown samlown merged commit 679d2eb into invopop:main Sep 23, 2022
@paulcacheux
Copy link
Contributor Author

@samlown do you plan to create a release tag for this ? Or are you waiting on something else ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants