Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for anyof_required and anyof_type #46

Merged
merged 4 commits into from Nov 1, 2022

Conversation

deepjyoti30
Copy link
Contributor

As discussed in #41 anyof_required is not supported unlike oneof_required.

This PR adds support for anyof_required and anyof_type so that they are picked up during schema generation.

Things added:

  • anyof_required support
  • anyof_type support
  • Tests for anyof_required and anyof_type for both root and child (tests passed).

@deepjyoti30
Copy link
Contributor Author

@samlown Can you take a look at this PR? This is a fix for the issue mentioned, as discussed before.

@siddharthlatest
Copy link

@samlown Can this PR be merged?

Copy link
Contributor

@samlown samlown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! I'm not totally convinced on the scaleability of this approach, but given that oneof is there already, it's hard to argue against anyof.

@samlown samlown merged commit 55c890f into invopop:main Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants