Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump pdfjs-dist to >3 #170

Open
kpsherva opened this issue Jan 12, 2023 · 2 comments · May be fixed by #203
Open

bump pdfjs-dist to >3 #170

kpsherva opened this issue Jan 12, 2023 · 2 comments · May be fixed by #203

Comments

@kpsherva
Copy link
Contributor 

    since you are on this, what you if you try to bump `pdfjs-dist` to `>3`? (and check if it works) :)

Originally posted by @ntarocco in #168 (comment)
@kpsherva kpsherva changed the title since you are on this, what you if you try to bump pdfjs-dist to >3? (and check if it works) :) bump pdfjs-dist to >3 Jan 12, 2023
@max-moser
Copy link
Contributor

Further hints provided by @kpsherva:

Semantics of the # syntax: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Classes/Private_class_fields
Webpack issue: webpack/webpack#10216

@slint slint mentioned this issue Feb 21, 2023
Open
@carlinmack
Copy link
Contributor

Related mozilla/pdf.js#17953 (comment)

@carlinmack carlinmack linked a pull request May 8, 2024 that will close this issue
Open
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade PDFJS carlinmack/invenio-previewer
3 participants
@max-moser @carlinmack @kpsherva