Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Exception thrown (and message shown) for zip files with a large amount of files #103

Open
nielsdrost opened this issue Sep 6, 2019 · 0 comments

Comments

@nielsdrost
Copy link

If a file with over 1000 entries is previed with Invenio (in this case on Zenodo) the error message seems to be "Zipfile is not previewable" instead of "Zipfile is too large to preview" which I would expect.

The zip previewer seem to throw the wrong exception when a file with >1000 files is previewed. I would expect a zipfile.LargeZipFile to be thrown. But perhaps I am not understanding the code correctly.

raise BufferError('Too many files inside the ZIP file.')

Example here: https://doi.org/10.5281/zenodo.3367497

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant