Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AuthClient shouldn't subclass Session. #16

Open
dreid opened this issue Oct 29, 2019 · 2 comments
Open

AuthClient shouldn't subclass Session. #16

dreid opened this issue Oct 29, 2019 · 2 comments

Comments

@dreid
Copy link

dreid commented Oct 29, 2019

It doesn't need to be a Session to have a Session. Subclassing Session drastically increases it's API surface for no benefit.
@fjolin-intuit
Copy link
Collaborator

Hi @dreid. Thanks for posting the issue - We are having a look currently and will consider removing the subclass.

@fjolin-intuit
Copy link
Collaborator

@dreid We are opening up our clients for contribution for hacktoberfest.

@AalokAhluwalia AalokAhluwalia mentioned this issue Oct 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dreid @fjolin-intuit