Size limit support #691
Size limit support #691
Conversation
The docs are all located here and get published to Per #690
IMO, I don't think a system-wide size-limit would really provide a whole lot of value. This is one of the reasons we went with a % increase approach since that would take into account the baseline complexities of each component. With 1 global upper-bound, components like a I think a per-component size limit would be right way to go about this. |
|
@adierkens Updated to support package-specific size limits! It still supports global limits, but yeah I don't see that being used often. Feel free to re-review. In order to support package-local configuration I needed to refactor the cc. @yucho |
| @@ -1,4 +1,5 @@ | |||
| import { monorepoName, createLogger } from '@design-systems/cli-utils'; | |||
| import { cosmiconfigSync as load } from 'cosmiconfig'; | |||
There was a problem hiding this comment.
💡 would prefer to use @design-systems/load-config here, but trying to link that resulted in a weird circular dependency issue that broke installation (see previous build). Got tired of fighting with that, but if someone else wants to tackle that optimization then by all means.
|
Thanks for the approval @kelyvin! Can you hold off on merging for the time being? I have been meaning to attach a demo to this PR, and IIRC I was having difficulty that suggested this feature wasn't working. I need to carve out some time to revisit this. I'll nudge you when this is ready. |
What Changed
fixes #690
Adds a new option for
ds sizethat enables enforcement of a limit on component bundles. Refactors thesizeplugin significantly in order to support locally-scoped configuration options, namely, thesizeLimitoption.Why
I'm building a new Design System component and want to enforce a limit on the component as a whole, rather than simply on incoming changesets
Todo:
gh-pagesbranch. What's the process for adding to that? Just a separate PR togh-pages?📦 Published PR as canary version:
4.14.1--canary.691.19342.0✨ Test out this PR locally via:
npm install @design-systems/babel-plugin-include-styles@4.14.1--canary.691.19342.0 npm install @design-systems/babel-plugin-replace-styles@4.14.1--canary.691.19342.0 npm install @design-systems/cli-utils@4.14.1--canary.691.19342.0 npm install @design-systems/cli@4.14.1--canary.691.19342.0 npm install @design-systems/core@4.14.1--canary.691.19342.0 npm install @design-systems/create@4.14.1--canary.691.19342.0 npm install @design-systems/docs@4.14.1--canary.691.19342.0 npm install @design-systems/eslint-config@4.14.1--canary.691.19342.0 npm install @design-systems/hooks@4.14.1--canary.691.19342.0 npm install @design-systems/load-config@4.14.1--canary.691.19342.0 npm install @design-systems/next-esm-css@4.14.1--canary.691.19342.0 npm install @design-systems/plugin@4.14.1--canary.691.19342.0 npm install @design-systems/stylelint-config@4.14.1--canary.691.19342.0 npm install @design-systems/svg-icon-builder@4.14.1--canary.691.19342.0 npm install @design-systems/utils@4.14.1--canary.691.19342.0 npm install @design-systems/build@4.14.1--canary.691.19342.0 npm install @design-systems/bundle@4.14.1--canary.691.19342.0 npm install @design-systems/clean@4.14.1--canary.691.19342.0 npm install @design-systems/create-command@4.14.1--canary.691.19342.0 npm install @design-systems/dev@4.14.1--canary.691.19342.0 npm install @design-systems/lint@4.14.1--canary.691.19342.0 npm install @design-systems/playroom@4.14.1--canary.691.19342.0 npm install @design-systems/proof@4.14.1--canary.691.19342.0 npm install @design-systems/size@4.14.1--canary.691.19342.0 npm install @design-systems/storybook@4.14.1--canary.691.19342.0 npm install @design-systems/test@4.14.1--canary.691.19342.0 npm install @design-systems/update@4.14.1--canary.691.19342.0 # or yarn add @design-systems/babel-plugin-include-styles@4.14.1--canary.691.19342.0 yarn add @design-systems/babel-plugin-replace-styles@4.14.1--canary.691.19342.0 yarn add @design-systems/cli-utils@4.14.1--canary.691.19342.0 yarn add @design-systems/cli@4.14.1--canary.691.19342.0 yarn add @design-systems/core@4.14.1--canary.691.19342.0 yarn add @design-systems/create@4.14.1--canary.691.19342.0 yarn add @design-systems/docs@4.14.1--canary.691.19342.0 yarn add @design-systems/eslint-config@4.14.1--canary.691.19342.0 yarn add @design-systems/hooks@4.14.1--canary.691.19342.0 yarn add @design-systems/load-config@4.14.1--canary.691.19342.0 yarn add @design-systems/next-esm-css@4.14.1--canary.691.19342.0 yarn add @design-systems/plugin@4.14.1--canary.691.19342.0 yarn add @design-systems/stylelint-config@4.14.1--canary.691.19342.0 yarn add @design-systems/svg-icon-builder@4.14.1--canary.691.19342.0 yarn add @design-systems/utils@4.14.1--canary.691.19342.0 yarn add @design-systems/build@4.14.1--canary.691.19342.0 yarn add @design-systems/bundle@4.14.1--canary.691.19342.0 yarn add @design-systems/clean@4.14.1--canary.691.19342.0 yarn add @design-systems/create-command@4.14.1--canary.691.19342.0 yarn add @design-systems/dev@4.14.1--canary.691.19342.0 yarn add @design-systems/lint@4.14.1--canary.691.19342.0 yarn add @design-systems/playroom@4.14.1--canary.691.19342.0 yarn add @design-systems/proof@4.14.1--canary.691.19342.0 yarn add @design-systems/size@4.14.1--canary.691.19342.0 yarn add @design-systems/storybook@4.14.1--canary.691.19342.0 yarn add @design-systems/test@4.14.1--canary.691.19342.0 yarn add @design-systems/update@4.14.1--canary.691.19342.0