Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests do not fail if coverage does not meet thresholds #670

Open
kennethbigler opened this issue Nov 2, 2021 · 0 comments
Open

Tests do not fail if coverage does not meet thresholds #670

kennethbigler opened this issue Nov 2, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@kennethbigler
Copy link

Describe the bug

When running yarn test, if your tests do not meet jest coverage thresholds, your tests will still pass.

To Reproduce

Add a coverage threshold that is not met, and verify that test will still pass, even though an error is showing.

Expected behavior

If coverage thresholds are added, and they aren't met, the tests should fail. Preferably it would specify that it failed due to coverage.

Screenshots

image (3)

Desktop (please complete the following information):

  • OS: MacOS Big Sur (11.6)
  • Browser: N/A
  • Version "@design-systems/cli": "4.13.1",

Additional context

@kennethbigler kennethbigler added the bug Something isn't working label Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant