Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Why pr-check doesn't have an option to throw an error? #2367

Open
pavelkeyzik opened this issue May 22, 2023 · 1 comment
Open

Comments

@pavelkeyzik
Copy link

The question I have is about the way pr-check works in GitHub Actions. When I run it in actions, the script runs and exits with 0, so in GitHub Actions I see that everything is okay, but in my PR I see an error. I didn't find any option, to exit with code 1 if there are some issues.

The reason why I need it is that my workflow contains two steps (Check -> Build) and when Check is failed (lint, or no label in PR) I want to throw an error and ignore build scripts.

Actual result:

  • On the Actions page it says that the job is completed with no errors
  • On the PR page it says "No semver label!"

Expected result:

  • On the Actions page it shows an error and the next job (build) is not starting
  • On the PR page it says "No semver label"

Let me know if there is another approach I could use for that or if you need some repo to see the problem 😊

@hipstersmoothie
Copy link
Collaborator

I haven't had the time to get the pr-check working in actions. if you want to submit a pr i'll definitely help get it merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants