fixing gradle issue #2116

ykhandelwal913 · 2021-12-06T18:05:52Z

Release Notes

This release fixes the Gradle plugin (#2608) for Gradle 6.8+.

What Changed

#2068 has more details

Why

Trying to update the gradle auto plugin to run the individual release task instead of release uber task.
Todo:

Change Type

Indicate the type of change your pull request is:

patch

🐤 Download canary assets:

auto-linux--canary.2116.25204.gz
auto-macos--canary.2116.25204.gz
auto-win.exe--canary.2116.25204.gz

📦 Published PR as canary version: under canary scope @auto-canary@10.32.4--canary.2116.25204.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@10.32.4--canary.2116.25204.0
npm install @auto-canary/auto@10.32.4--canary.2116.25204.0
npm install @auto-canary/core@10.32.4--canary.2116.25204.0
npm install @auto-canary/package-json-utils@10.32.4--canary.2116.25204.0
npm install @auto-canary/all-contributors@10.32.4--canary.2116.25204.0
npm install @auto-canary/brew@10.32.4--canary.2116.25204.0
npm install @auto-canary/chrome@10.32.4--canary.2116.25204.0
npm install @auto-canary/cocoapods@10.32.4--canary.2116.25204.0
npm install @auto-canary/conventional-commits@10.32.4--canary.2116.25204.0
npm install @auto-canary/crates@10.32.4--canary.2116.25204.0
npm install @auto-canary/docker@10.32.4--canary.2116.25204.0
npm install @auto-canary/exec@10.32.4--canary.2116.25204.0
npm install @auto-canary/first-time-contributor@10.32.4--canary.2116.25204.0
npm install @auto-canary/gem@10.32.4--canary.2116.25204.0
npm install @auto-canary/gh-pages@10.32.4--canary.2116.25204.0
npm install @auto-canary/git-tag@10.32.4--canary.2116.25204.0
npm install @auto-canary/gradle@10.32.4--canary.2116.25204.0
npm install @auto-canary/jira@10.32.4--canary.2116.25204.0
npm install @auto-canary/magic-zero@10.32.4--canary.2116.25204.0
npm install @auto-canary/maven@10.32.4--canary.2116.25204.0
npm install @auto-canary/microsoft-teams@10.32.4--canary.2116.25204.0
npm install @auto-canary/npm@10.32.4--canary.2116.25204.0
npm install @auto-canary/omit-commits@10.32.4--canary.2116.25204.0
npm install @auto-canary/omit-release-notes@10.32.4--canary.2116.25204.0
npm install @auto-canary/pr-body-labels@10.32.4--canary.2116.25204.0
npm install @auto-canary/released@10.32.4--canary.2116.25204.0
npm install @auto-canary/s3@10.32.4--canary.2116.25204.0
npm install @auto-canary/sbt@10.32.4--canary.2116.25204.0
npm install @auto-canary/slack@10.32.4--canary.2116.25204.0
npm install @auto-canary/twitter@10.32.4--canary.2116.25204.0
npm install @auto-canary/upload-assets@10.32.4--canary.2116.25204.0
npm install @auto-canary/vscode@10.32.4--canary.2116.25204.0
# or 
yarn add @auto-canary/bot-list@10.32.4--canary.2116.25204.0
yarn add @auto-canary/auto@10.32.4--canary.2116.25204.0
yarn add @auto-canary/core@10.32.4--canary.2116.25204.0
yarn add @auto-canary/package-json-utils@10.32.4--canary.2116.25204.0
yarn add @auto-canary/all-contributors@10.32.4--canary.2116.25204.0
yarn add @auto-canary/brew@10.32.4--canary.2116.25204.0
yarn add @auto-canary/chrome@10.32.4--canary.2116.25204.0
yarn add @auto-canary/cocoapods@10.32.4--canary.2116.25204.0
yarn add @auto-canary/conventional-commits@10.32.4--canary.2116.25204.0
yarn add @auto-canary/crates@10.32.4--canary.2116.25204.0
yarn add @auto-canary/docker@10.32.4--canary.2116.25204.0
yarn add @auto-canary/exec@10.32.4--canary.2116.25204.0
yarn add @auto-canary/first-time-contributor@10.32.4--canary.2116.25204.0
yarn add @auto-canary/gem@10.32.4--canary.2116.25204.0
yarn add @auto-canary/gh-pages@10.32.4--canary.2116.25204.0
yarn add @auto-canary/git-tag@10.32.4--canary.2116.25204.0
yarn add @auto-canary/gradle@10.32.4--canary.2116.25204.0
yarn add @auto-canary/jira@10.32.4--canary.2116.25204.0
yarn add @auto-canary/magic-zero@10.32.4--canary.2116.25204.0
yarn add @auto-canary/maven@10.32.4--canary.2116.25204.0
yarn add @auto-canary/microsoft-teams@10.32.4--canary.2116.25204.0
yarn add @auto-canary/npm@10.32.4--canary.2116.25204.0
yarn add @auto-canary/omit-commits@10.32.4--canary.2116.25204.0
yarn add @auto-canary/omit-release-notes@10.32.4--canary.2116.25204.0
yarn add @auto-canary/pr-body-labels@10.32.4--canary.2116.25204.0
yarn add @auto-canary/released@10.32.4--canary.2116.25204.0
yarn add @auto-canary/s3@10.32.4--canary.2116.25204.0
yarn add @auto-canary/sbt@10.32.4--canary.2116.25204.0
yarn add @auto-canary/slack@10.32.4--canary.2116.25204.0
yarn add @auto-canary/twitter@10.32.4--canary.2116.25204.0
yarn add @auto-canary/upload-assets@10.32.4--canary.2116.25204.0
yarn add @auto-canary/vscode@10.32.4--canary.2116.25204.0

sumwatshade · 2021-12-06T19:19:17Z

@ykhandelwal913 can you add details and context to the PR so for future reference we can understand this changeset better?

Checks are failing on CI, @adierkens i assume this is because we don't propagate secrets to forks?

ykhandelwal913 · 2021-12-06T19:27:05Z

@sumwatshade sure let me add the details. I am trying to fix #2068

ykhandelwal913 · 2021-12-06T20:01:26Z

@sumwatshade @adierkens let me know if there is anything i need to do to fix the build.

sugarmanz

Just want to make sure this has been tested on the latest versions of Gradle, 6.8, 7.0, etc.

sugarmanz · 2021-12-06T20:06:24Z

plugins/gradle/src/index.ts

@@ -112,12 +112,9 @@ export default class GradleReleasePluginPlugin implements IPlugin {
    if (buildFlag) {
      // don't create release, tag, or commit since auto will do this
      await execPromise(this.options.gradleCommand, [
-        "release",


This code is the same as the other block in the conditional. At the very least we need to ensure that the buildFlag is respected and the projects buildTasks is called to ensure that anything relying on the version string is re-built.

I'm thinking that we'll probably also want to ensure that other features of the release plugin are still being utilized here, like checkSnapshotDependencies.

@ykhandelwal913 This looks better. The only thing I see here that is a little confusing is the createScmAdapter, initScmAdapter, and unSnapshotVersion task calls.

For both createScmAdapter and initScmAdapter, I can maybe see some issues here if those aren't initialized by some dependent task, but would like to know for sure if you saw an error without them.

For unSnapshotVersion, I think we should try to avoid this one if we can since this would actually change the version in the version file, which we don't want because we are already changing it ourselves with updateVersion.

Does that make sense?

createScmAdapter and initScmAdapter are internal dependency to subsequent task. Hence added them. Removed the unSnapshot version

.all-contributorsrc

adierkens · 2021-12-07T01:17:56Z

I don't see anything in the circle config that would prevent this from building -- it doesn't look like this PR is being picked up by the auto circleci org, but rather the one from @ykhandelwal913 fork. The only thing that I can think of is the PR is made from main and maybe circle is filtering out by branch name?

codecov · 2021-12-08T16:50:39Z

Codecov Report

Merging #2116 (e3fc4bd) into main (956f88a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2116   +/-   ##
=======================================
  Coverage   80.19%   80.19%           
=======================================
  Files          66       66           
  Lines        5413     5413           
  Branches     1263     1263           
=======================================
  Hits         4341     4341           
  Misses        709      709           
  Partials      363      363

Impacted Files	Coverage Δ
plugins/gradle/src/index.ts	`76.66% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 956f88a...e3fc4bd. Read the comment docs.

ykhandelwal913 · 2021-12-08T19:43:35Z

I don't see anything in the circle config that would prevent this from building -- it doesn't look like this PR is being picked up by the auto circleci org, but rather the one from @ykhandelwal913 fork. The only thing that I can think of is the PR is made from main and maybe circle is filtering out by branch name?

Fixed the build issue as build was running from my fork instead of intuit org. Once made the changes, things worked.

sugarmanz · 2021-12-10T09:26:17Z

@adierkens looks like I don't have perms to merge, but looks good to me!

@ykhandelwal913 could you just write small release notes saying this fixes the plugin for Gradle 6.8+ and link the GitHub ticket? Thanks.

ykhandelwal913 · 2021-12-10T09:28:03Z

@adierkens looks like I don't have perms to merge, but looks good to me!

@ykhandelwal913 could you just write small release notes saying this fixes the plugin for Gradle 6.8+ and link the GitHub ticket? Thanks.

will do

adierkens · 2021-12-10T19:04:48Z

🚀 PR was released in v10.32.4 🚀

yogeshkhandelwal added 3 commits December 6, 2021 23:35

fixing gradle issue

f7a3ce6

updating username

421b41f

fixing test

fde8db3

sugarmanz requested changes Dec 6, 2021

View reviewed changes

ykhandelwal913 closed this Dec 7, 2021

ykhandelwal913 reopened this Dec 7, 2021

yogeshkhandelwal added 3 commits December 7, 2021 09:52

fixing test

972fa56

testing with release

78123b1

fixing gradle issue

c9b8996

adierkens added the patch label Dec 8, 2021

yogeshkhandelwal added 2 commits December 8, 2021 17:05

removing unused variable

ce3ec32

fixing build

cf26a88

yogeshkhandelwal added 4 commits December 10, 2021 00:05

Adding individual tasks of release plugin to

7ae6d6a

Adding some more task

5a1bf13

fixing test

f5c100e

Removing unsnapshot version

e3fc4bd

sugarmanz approved these changes Dec 10, 2021

View reviewed changes

adierkens merged commit 123fcfd into intuit:main Dec 10, 2021

sugarmanz mentioned this pull request Dec 10, 2021

Gradle plugin does not work with Gradle version +6.8 #2068

Closed

adierkens added the released label Dec 10, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fixing gradle issue #2116

fixing gradle issue #2116

ykhandelwal913 commented Dec 6, 2021 •

edited

Loading

sumwatshade commented Dec 6, 2021

ykhandelwal913 commented Dec 6, 2021

ykhandelwal913 commented Dec 6, 2021 •

edited

Loading

sugarmanz left a comment

sugarmanz Dec 6, 2021

sugarmanz Dec 6, 2021

sugarmanz Dec 10, 2021

ykhandelwal913 Dec 10, 2021

adierkens commented Dec 7, 2021

codecov bot commented Dec 8, 2021 •

edited

Loading

ykhandelwal913 commented Dec 8, 2021

sugarmanz commented Dec 10, 2021

ykhandelwal913 commented Dec 10, 2021

adierkens commented Dec 10, 2021

fixing gradle issue #2116

fixing gradle issue #2116

Conversation

ykhandelwal913 commented Dec 6, 2021 • edited Loading

Release Notes

What Changed

Why

Change Type

sumwatshade commented Dec 6, 2021

ykhandelwal913 commented Dec 6, 2021

ykhandelwal913 commented Dec 6, 2021 • edited Loading

sugarmanz left a comment

Choose a reason for hiding this comment

sugarmanz Dec 6, 2021

Choose a reason for hiding this comment

sugarmanz Dec 6, 2021

Choose a reason for hiding this comment

sugarmanz Dec 10, 2021

Choose a reason for hiding this comment

ykhandelwal913 Dec 10, 2021

Choose a reason for hiding this comment

adierkens commented Dec 7, 2021

codecov bot commented Dec 8, 2021 • edited Loading

Codecov Report

ykhandelwal913 commented Dec 8, 2021

sugarmanz commented Dec 10, 2021

ykhandelwal913 commented Dec 10, 2021

adierkens commented Dec 10, 2021

ykhandelwal913 commented Dec 6, 2021 •

edited

Loading

ykhandelwal913 commented Dec 6, 2021 •

edited

Loading

codecov bot commented Dec 8, 2021 •

edited

Loading