Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use header auth mode for user and email requests #84

Merged
merged 1 commit into from Feb 5, 2020

Conversation

DazWorrall
Copy link
Contributor

@DazWorrall DazWorrall commented Feb 4, 2020

@Firefishy
Copy link

Firefishy commented Feb 4, 2020

This appears to be the fix for: #83

@casperisfine
Copy link

@BobbyMcWho @supernova32 sorry for the ping, but the GitHub deprecation emails are particularly noisy, so a timely merge would be ❤️ .

@BobbyMcWho
Copy link
Member

I'd be happy to merge, but I don't know who has the actual rubygems account to cut a release.

@casperisfine
Copy link

According to https://rubygems.org/gems/omniauth-github

It's @mbleigh and @tmilewski

@BobbyMcWho
Copy link
Member

We'll see if they respond. I've tried reaching out to them on a couple other omniauth projects to release new versions, with no reply.

@casperisfine
Copy link

Worst case, I think we can try to see with rubygems people. But let's wait a bit first.

Also, maybe it's better to merge this now, so that people can point their Gemfile to the master rather than a fork. And then see about the release in a separate issue?

@BobbyMcWho
Copy link
Member

Also, now that I look, I don't have write access for this repo, only omniauth/omniauth

@suprnova32 suprnova32 merged commit 4aca7b6 into omniauth:master Feb 5, 2020
@suprnova32
Copy link
Member

@BobbyMcWho thanks or reviewing the PR. I'll give you write access here as well.

@DazWorrall thanks for submitting the fixes :)

potomak added a commit to tomatoes-app/tomatoes that referenced this pull request Feb 16, 2020
Fix authentication using query params deprecation.

See omniauth/omniauth-github#84
masutaka added a commit to masutaka/github-organization-watcher that referenced this pull request Jan 1, 2021
…parameters

$ docker-compose run --rm app bundle update omniauth-github

See also omniauth/omniauth-github#84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation for authentication via URL query parameters
5 participants