Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make startCursor/endCursor optional #191

Closed
wilsonianb opened this issue Sep 30, 2022 · 1 comment · Fixed by #266
Closed

Make startCursor/endCursor optional #191

wilsonianb opened this issue Sep 30, 2022 · 1 comment · Fixed by #266
Assignees

Comments

@wilsonianb
Copy link
Contributor

The pageInfo object in list responses should not require startCursor/endCursor

- startCursor
- endCursor

They are technically required in the relay spec, but there is an open issue about making them optional (for when the result is empty), and they are currently optional in Rafiki:

We could forgo this change by instead not having the Open Payments API list responses match relay:

@mkurapov
Copy link
Contributor

mkurapov commented Jun 6, 2023

Not required anymore in the relay spec:
Screenshot 2023-06-06 at 17 38 02

We should go ahead and make them optional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants