Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interledger-http API review for v1.0-rc #574

Closed
6 tasks done
gakonst opened this issue Dec 18, 2019 · 2 comments
Closed
6 tasks done

interledger-http API review for v1.0-rc #574

gakonst opened this issue Dec 18, 2019 · 2 comments
Assignees
Labels
crater/interledger-http docs v1.0 Issues which need to be handled for a v1.0 release

Comments

@gakonst
Copy link
Member

gakonst commented Dec 18, 2019

interledger-http public items marked with x are documented. Non-exported items are not taken into account. Follows format from #561.

Part of #557.

  • HttpAccount (trait)
  • HttpStore (trait)
  • deserialize_json (fn)
  • HttpServer (struct)
    • as_filter(): Should we put some docs on the exact API endpoints this exposes or point to the spec?
  • HttpClientService (struct)
    • Maybe document that send_request serializes (& oer encodes) the ILP packet before sending it to the next service?
  • error (module)
    • Should we extract this to a separate crate? Seems generic enough, we discussed this another time.
@gakonst gakonst added this to To do in Towards a v1.0 Dec 18, 2019
@gakonst gakonst mentioned this issue Jan 20, 2020
11 tasks
@gakonst gakonst moved this from To do to In progress in Towards a v1.0 Jan 20, 2020
@gakonst gakonst self-assigned this Jan 20, 2020
@gakonst gakonst added v1.0 Issues which need to be handled for a v1.0 release docs labels Jan 20, 2020
@gakonst gakonst moved this from In progress to Waiting Review / Response in Towards a v1.0 Jan 20, 2020
@bstrie
Copy link
Contributor

bstrie commented Feb 4, 2020

  • as_filter: give a brief summary but link to the spec

@gakonst
Copy link
Member Author

gakonst commented Feb 4, 2020

@gakonst gakonst closed this as completed Feb 4, 2020
Towards a v1.0 automation moved this from Waiting Review / Response to Done Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crater/interledger-http docs v1.0 Issues which need to be handled for a v1.0 release
Projects
No open projects
Development

No branches or pull requests

2 participants