You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Should to_prepare be implemented as Prepare::from(src: RouteControlRequest)?
RouteProp
Should we convert it to pub(crate)?
CcpRouteManager
CcpRouteManagerBuilder: Does this need to be documented? Its fields are docuemnted, and given that it's a builder its functionality should be intuitive.
The text was updated successfully, but these errors were encountered:
No opinion on Mode, do whatever seems most conservative.
If RouteProp can be made pub(crate), then absolutely. Reducing the public surface area is good.
CcpRouteManagerBuilder: Even just a line saying something like "See documentation on fields" would be nice to show that documentation wasn't just forgotten about.
interledger-ccp
public items marked with x are documented. Non-exported items are not taken into account. Follows format from #561.Part of #557.
CcpRoutingAccount
(trait)RouteManagerStore
(trait):CcpRoutingStore
? That would make it consistent with how the other Account/Store pairs are named.RoutingRelation
Mode
Idle
mode. Should we remove Mode altogether and assumeSync
? Added the first draft of Route Broadcasting Protocol rfcs#455 is closed and seems stale atm, so I am not sure what's the path towards CCP standardizationRouteControlRequest
to_prepare
be implemented asPrepare::from(src: RouteControlRequest)
?RouteProp
pub(crate)
?CcpRouteManager
CcpRouteManagerBuilder
: Does this need to be documented? Its fields are docuemnted, and given that it's a builder its functionality should be intuitive.The text was updated successfully, but these errors were encountered: