Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using cargo-vendor #224

Closed
bstrie opened this issue Aug 17, 2019 · 3 comments
Closed

Consider using cargo-vendor #224

bstrie opened this issue Aug 17, 2019 · 3 comments

Comments

@bstrie
Copy link
Contributor

bstrie commented Aug 17, 2019

As of today's 1.37 release, cargo-vendor (https://crates.io/crates/cargo-vendor) is now available in Cargo by default. If we wish to embrace the full monorepo philosophy we could use this to vendor all of our dependencies directly, which would at least suffice to prevent unforeseen version conflicts if a user manages to compile using a combination of versions that we're not. May want to wait on #140, although this does serve as a nice way to easily visualize how many libraries we're currently transitively depending on, which may spur on that effort. :)

@emschwartz
Copy link
Member

This seems most useful when you depend on git sources rather than crates on crates.io, am I wrong about that? (In general, I think we should avoid depending on git sources)

@tarcieri
Copy link
Collaborator

The main thing I've considered this for is making code changes in dependencies visible as part of a PR review process.

I think the practicality of that will depend on the nature of your project, and this one in particular has enough dependencies that may be impractical, but as they say, "many eyes make all bugs shallow", and if the code changes in dependencies are visible in each PR to the project, even if e.g. trojans aren't spotted right away prior to merging, you at least increase the probability of someone else reviewing the PR noticing.

@emschwartz
Copy link
Member

I don't think we're going to use this now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants