Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extern crate directives since we are in Rust 2018 #132

Closed
gakonst opened this issue Jul 15, 2019 · 4 comments
Closed

Remove extern crate directives since we are in Rust 2018 #132

gakonst opened this issue Jul 15, 2019 · 4 comments
Assignees
@bstrie
Labels
enhancement good-first-issue

Comments

@gakonst
Copy link
Member

gakonst commented Jul 15, 2019 •
edited

I am pretty sure you don't need all these extern crate directives in rust 2018.

https://doc.rust-lang.org/nightly/edition-guide/rust-2018/module-system/path-clarity.html

Originally posted by @zmanian in #125
gakonst added a commit that referenced this issue Jul 15, 2019
@gakonst
update imports to Rust 2018
7afec72 
tracked for rest of repository in: #132

tower_web complains if we do:
use tower_web::impl_web, so it's left for later
@bstrie bstrie mentioned this issue Jul 18, 2019
Merged
@bstrie
Copy link
Contributor

bstrie commented Jul 19, 2019

This is almost done; tower-web is a sticking point due to some deficiencies in its procedural macro expansions. See also #146

@emschwartz
Copy link
Member

Can this be closed now?

@gakonst
Copy link
Member Author

gakonst commented Oct 3, 2019

Let's keep this open until we replace tower-web with warp in the Settlement and Settlement Engines crates, for some reason doing use tower_web::impl_web does not work.

@gakonst gakonst mentioned this issue Oct 3, 2019
Merged
@bstrie
Copy link
Contributor

bstrie commented Oct 14, 2019

This specific issue was fixed in #400, so I'll close this. Removing the tower_web dependency entirely can fall under #140.

@bstrie bstrie closed this as completed Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bstrie bstrie

Labels
enhancement good-first-issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bstrie @emschwartz @gakonst