Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compilation console color all red is "rude" #1261

Closed
Geobert opened this issue May 22, 2017 · 5 comments · Fixed by #3312
Closed

Compilation console color all red is "rude" #1261

Geobert opened this issue May 22, 2017 · 5 comments · Fixed by #3312
Assignees
@mchernyavsky

Comments

@Geobert
Copy link

Geobert commented May 22, 2017

Minor issue here, but I found having all the compiler output red feels "rude".
I sometime believe that I have errors but it's only warnings (mainly because my function has just been written and not used yet).

Can we have the default colours from the compiler?
@matklad
Copy link
Member

matklad commented May 22, 2017

Can we have the default colours from the compiler?

This is exactly how it is supposed to work :) Could you give us a screenshot of how compiler output looks like now? What operation system are you using?

cc @alygin

@Geobert
Copy link
Author

Geobert commented May 22, 2017 •
edited

Thank you for your answer :)
Win 10, IntelliJ 2017.1.3, Rust 0.1.0.1991
image

@alygin
Copy link
Member

alygin commented May 22, 2017

The problem here is that Rust only has two options for colored output on Windows: it uses Win API calls by default (not supported by IntelliJ platform, as far as I know) and the msys mode that produced broken output last time I checked. That's why we decided to only use colors on Linux and Mac.

I'll have a look at how it works now. There were changes in the term crate since then, so maybe it's already fixed and we can have colored output on Windows (though the issue is still open).

@farodin91 farodin91 mentioned this issue Jun 8, 2017
Closed
@Geobert
Copy link
Author

Geobert commented Aug 16, 2017

:'(
Stebalien/term#58 (comment)

@matklad
Copy link
Member

matklad commented Aug 16, 2017

Nightly Cargo now emits ANSI escapes on windows, so we need to reconsider the situation.

@amakeev amakeev mentioned this issue Oct 15, 2018
Closed
@mchernyavsky mchernyavsky self-assigned this Nov 30, 2018
@mchernyavsky mchernyavsky mentioned this issue Jan 31, 2019
Merged
bors bot added a commit that referenced this issue Feb 22, 2019
@bors
Merge #3312
bff5f3a 
3312: Handle 8-bit and 24-bit ANSI color escapes in console r=ortem a=mchernyavsky

Fixes #1261 (already fixed?)
Closes #1630 (?)
Fixes #1966
Fixes #2463

Thanks @kumbayo for [this](#1966 (comment)) comment!

TODO:
* Fix issue with white color on Windows
#### Update

Looks like a Rustc issue.

macOS Mojave:
```
^[[0m^[[1mFor more information about this error, try `rustc --explain E0369`.^[[0m
```

Windows 10:
```
^[[0m^[[1m^[[38;5;15mFor more information about this error, try `rustc --explain E0369`.^[[0m^M
```

As you can see, on Windows, Rustc prepends `^[[38;5;15m` control sequence to some chunks of text, which forces console use white color for the foreground. This is a problem, as the default background in IDEA is also white.

Not sure how to fix it (and whether to do it at all). The user can configure color mapping in the console (`Preferences > Editor > Console Scheme > Console Colors > ANSI Colors`).

* Check #1842 (does it work as expected?)

Co-authored-by: mchernyavsky <chemike47@gmail.com>
Co-authored-by: Mikhail Chernyavsky <chemike47@gmail.com>
bors bot added a commit that referenced this issue Feb 22, 2019
@bors
Merge #3312
9994372 
3312: Handle 8-bit and 24-bit ANSI color escapes in console r=ortem a=mchernyavsky

Fixes #1261 (already fixed?)
Closes #1630 (?)
Fixes #1966
Fixes #2463
Fixes #1842 (does it work as expected?)

Thanks @kumbayo for [this](#1966 (comment)) comment!

TODO:
* Fix issue with white color on Windows
#### Update

Looks like a Rustc issue.

macOS Mojave:
```
^[[0m^[[1mFor more information about this error, try `rustc --explain E0369`.^[[0m
```

Windows 10:
```
^[[0m^[[1m^[[38;5;15mFor more information about this error, try `rustc --explain E0369`.^[[0m^M
```

As you can see, on Windows, Rustc prepends `^[[38;5;15m` control sequence to some chunks of text, which forces console use white color for the foreground. This is a problem, as the default background in IDEA is also white.

Not sure how to fix it (and whether to do it at all). The user can configure color mapping in the console (`Preferences > Editor > Console Scheme > Console Colors > ANSI Colors`).

Co-authored-by: mchernyavsky <chemike47@gmail.com>
Co-authored-by: Mikhail Chernyavsky <chemike47@gmail.com>
bors bot added a commit that referenced this issue Feb 22, 2019
@bors
Merge #3312
2ebbb20 
3312: Handle 8-bit and 24-bit ANSI color escapes in console r=ortem a=mchernyavsky

Fixes #1261 (already fixed?)
Closes #1630 (?)
Fixes #1966
Fixes #2463
Fixes #1842 (does it work as expected?)

Thanks @kumbayo for [this](#1966 (comment)) comment!

TODO:
* Fix issue with white color on Windows
#### Update

Looks like a Rustc issue.

macOS Mojave:
```
^[[0m^[[1mFor more information about this error, try `rustc --explain E0369`.^[[0m
```

Windows 10:
```
^[[0m^[[1m^[[38;5;15mFor more information about this error, try `rustc --explain E0369`.^[[0m^M
```

As you can see, on Windows, Rustc prepends `^[[38;5;15m` control sequence to some chunks of text, which forces console use white color for the foreground. This is a problem, as the default background in IDEA is also white.

Not sure how to fix it (and whether to do it at all). The user can configure color mapping in the console (`Preferences > Editor > Console Scheme > Console Colors > ANSI Colors`).

Co-authored-by: mchernyavsky <chemike47@gmail.com>
Co-authored-by: Mikhail Chernyavsky <chemike47@gmail.com>
bors bot added a commit that referenced this issue Feb 22, 2019
@bors
Merge #3312
70c3962 
3312: Handle 8-bit and 24-bit ANSI color escapes in console r=ortem a=mchernyavsky

Fixes #1261 (already fixed?)
Closes #1630 (?)
Fixes #1966
Fixes #2463
Fixes #1842 (does it work as expected?)

Thanks @kumbayo for [this](#1966 (comment)) comment!

TODO:
* Fix issue with white color on Windows
#### Update

Looks like a Rustc issue.

macOS Mojave:
```
^[[0m^[[1mFor more information about this error, try `rustc --explain E0369`.^[[0m
```

Windows 10:
```
^[[0m^[[1m^[[38;5;15mFor more information about this error, try `rustc --explain E0369`.^[[0m^M
```

As you can see, on Windows, Rustc prepends `^[[38;5;15m` control sequence to some chunks of text, which forces console use white color for the foreground. This is a problem, as the default background in IDEA is also white.

Not sure how to fix it (and whether to do it at all). The user can configure color mapping in the console (`Preferences > Editor > Console Scheme > Console Colors > ANSI Colors`).

Co-authored-by: mchernyavsky <chemike47@gmail.com>
Co-authored-by: Mikhail Chernyavsky <chemike47@gmail.com>
@bors bors bot closed this as completed in #3312 Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mchernyavsky mchernyavsky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle 8-bit and 24-bit ANSI color escapes in console
4 participants
@Geobert @matklad @alygin @mchernyavsky