Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT]: Add "Require workflows to pass before merging" support to github_organization_ruleset #1970

Closed
1 task done
lawliet89 opened this issue Oct 19, 2023 · 3 comments · Fixed by #2082
Closed
1 task done

[FEAT]: Add "Require workflows to pass before merging" support to github_organization_ruleset #1970

lawliet89 opened this issue Oct 19, 2023 · 3 comments · Fixed by #2082
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Feature New feature or request

Comments

@lawliet89
Copy link

Describe the need

Add support for "required workflow" rule in the organisation ruleset resource github_organization_ruleset.

SDK Version

No response

API Version

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@lawliet89 lawliet89 added Status: Triage This is being looked at and prioritized Type: Feature New feature or request labels Oct 19, 2023
@kfcampbell kfcampbell added Status: Up for grabs Issues that are ready to be worked on by anyone and removed Status: Triage This is being looked at and prioritized labels Oct 20, 2023
@relusc
Copy link
Contributor

relusc commented Jan 5, 2024

hi, we'd also like to see this feature being implemented and I am also up for contributing here, however this requires v57 of https://github.com/google/go-github. Is there some sort of timeline until v57 will be used in the provider ?

@kfcampbell
Copy link
Member

@relusc I've opened #2081 to update the go-github version in the project! That should be merged shortly.

@relusc relusc mentioned this issue Jan 8, 2024
Merged
4 tasks
@relusc
Copy link
Contributor

relusc commented Jan 8, 2024

Thanks @kfcampbell for the quick update :)

I have created #2082 which should resolve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add required_workflows to github_organization_ruleset
3 participants
@lawliet89 @kfcampbell @relusc