Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for client.authentication.k8s.io/v1 api #1049

Open
ahublersos opened this issue Feb 13, 2024 · 0 comments
Open

Add support for client.authentication.k8s.io/v1 api #1049

ahublersos opened this issue Feb 13, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@ahublersos
Copy link

ahublersos commented Feb 13, 2024

Purpose of the feature (why)

the client.authentication.k8s.io/v1beta1 api is deprecated and will be removed in a future Kubernetes release. The new version of this api is client.authentication.k8s.io/v1, but using that version in exec config gives this error:

E0213 10:28:08.147879   51131 memcache.go:265] couldn't get current server API group list: Get "https://api.<cluster-url>/api?timeout=32s": getting credentials: exec plugin is configured to use API version client.authentication.k8s.io/v1, plugin returned version client.authentication.k8s.io/v1beta1

Your idea (how)

Moving completely over to client.authentication.k8s.io/v1 may be a breaking change depending on users kubeconfigs and Kubernetes versions. Perhaps defaulting to the new v1 version but having a flag available to preserve the current v1beta1 version would be a good middle ground.

At the very least clientauthenticationv1beta1 in pkg/credentialplugin/writer/credential_plugin.go and integration_test/credetial_plugin_test.go will need to be updated.

It doesn't look like the ExecCredential object changes between API versions, so changes to the write() function and tests shoud be minimal.

client-authentication.v1 docs
client-authentication.v1beta1 docs

@ahublersos ahublersos added the enhancement New feature or request label Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant