pkg/operators: Fix tracing host events for mount namespace ID attache… #2879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eiffel-fl
commented
May 21, 2024
…r gadgets. Some attacher-based gadgets, like traceloop and advise seccomp-profile, need the mount namespace ID of the container to bet set. With --host, we only created a fake container structure containing only PID 1. So, traceloop and advise seccomp-profile would not work correctly as their required information were not set. To cope with this, we extend the fake container structure to also contain the mount namespace ID of PID 1. Fixes: 740976d ("pkg/operators: Enable tracing hosts events for attacher gadgets.") Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>
eiffel-fl
force-pushed
the
francis/fix-traceloop-host
branch
from
1581bac
to
b6269d6
Compare
mauriciovasquezbernal
approved these changes
May 22, 2024
|
Thank you for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
This PR fixes
--hostfor attacher-based gadgets relying on the mount namespace ID, like traceloop and advise seccomp-profile:$ sudo ./ig traceloop --host > /tmp/out ^C% $ grep ig /tmp/out 4 47530 ig nanosleep un… 7 47530 ig bpf cmd=3, uattr=0xc0004eb4f0, size=32 0 6 47530 ig bpf cmd=3, uattr=0xc0035394f0, size=32 0 7 47530 ig bpf cmd=3, uattr=0xc0004eb4f0, size=32 0 6 47530 ig bpf cmd=3, uattr=0xc0035394f0, size=32 0 7 47530 ig bpf cmd=3, uattr=0xc0004eb4f0, size=32 0 6 47530 ig bpf cmd=3, uattr=0xc0035394f0, size=32 0 6 47530 ig bpf un… 7 47530 ig bpf cmd=3, uattr=0xc0004eb4f0, size=32 0 7 47530 ig bpfBest regards.