Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin ffi and support ffi >= 0.13 #607

Closed
james-stocks opened this issue Jun 4, 2020 · 2 comments
Closed

Unpin ffi and support ffi >= 0.13 #607

james-stocks opened this issue Jun 4, 2020 · 2 comments

Comments

@james-stocks
Copy link

We had to pin ffi to <= 0.12.2 due to changes in 0.13.
It's pinned in both InSpec dependencies and in our omnibus Gemfile.
This is storing up a dependency problem for the future - we should unpin and troubleshoot what's going wrong.
The issue that was raised for ffi (ffi/ffi#784) suggests that there is no bug in ffi itself, but errors are now manifesting in other libraries that aren't using ffi 100% correctly (e.g. freeing memory, using fully correct function parameters) but have gotten away with it to-date.

@james-stocks james-stocks transferred this issue from inspec/inspec Jun 5, 2020
@james-stocks
Copy link
Author

Transferred this issue from inspec/inspec - train is where we need to troubleshoot the crash.

@tas50
Copy link
Contributor

tas50 commented Jul 2, 2020

Fixed in f6055c9

@tas50 tas50 closed this as completed Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants