Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to tokio 1.0 #2621

Closed
3 tasks done
mzabaluev opened this issue Oct 21, 2020 · 5 comments · Fixed by #2879
Closed
3 tasks done

Port to tokio 1.0 #2621

mzabaluev opened this issue Oct 21, 2020 · 5 comments · Fixed by #2879
Labels
epic high level issues Priority - Medium subsys-network network related technical debt issue to track potential technical dept we are introducing but will need care later.

Comments

@mzabaluev
Copy link
Contributor

mzabaluev commented Oct 21, 2020

Need to keep up with the async stack.

Dependencies needing upgrade

@mzabaluev mzabaluev added subsys-network network related technical debt issue to track potential technical dept we are introducing but will need care later. Priority - Medium labels Oct 21, 2020
@danielSanchezQ
Copy link
Contributor

danielSanchezQ commented Nov 13, 2020

We have two drafts with the build complete. Sadly we will not be able to update until some of our async dependencies are updated too.

At least:

  • Tonic
  • Warp

@mzabaluev
Copy link
Contributor Author

Sometimes procrastination saves you some work: we should target tokio 1.0 now.
As @danielSanchezQ mentioned, this makes sense to do when tonic and warp are updated to tokio 1.0.

@mzabaluev mzabaluev changed the title Port to tokio 0.3 Port to tokio 1.0 Dec 24, 2020
@danielSanchezQ
Copy link
Contributor

Hyper was just updated yesterday too. So lets hope warp and tonic will do so soon too.

@eugene-babichenko
Copy link
Contributor

Tonic is already on tokio 1.0, the relevant pull request in warp already has 70 comments and this is going to become a long story :D

@mzabaluev
Copy link
Contributor Author

Reopening to incorporate #2958.

@mzabaluev mzabaluev reopened this Jan 27, 2021
@mzabaluev mzabaluev added the epic high level issues label Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic high level issues Priority - Medium subsys-network network related technical debt issue to track potential technical dept we are introducing but will need care later.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants