From 6d7aeb10aaa78d794cc892650d92a60aa509cdba Mon Sep 17 00:00:00 2001 From: Sander Van Balen Date: Mon, 21 Feb 2022 16:21:06 +0100 Subject: [PATCH] Updated Makefile to disable mypy error limit (PR #3862) # Description Fixes python/mypy#10956 Thanks @bartv # Self Check: Strike through any lines that are not applicable (`~~line~~`) then check the box - [ ] Attached issue to pull request - [ ] Changelog entry - [ ] Type annotations are present - [ ] Code is clear and sufficiently documented - [ ] No (preventable) type errors (check using make mypy or make mypy-diff) - [ ] Sufficient test cases (reproduces the bug/tests the requested feature) - [ ] Correct, in line with design - [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: ) # Reviewer Checklist: - [ ] Sufficient test cases (reproduces the bug/tests the requested feature) - [ ] Code is clear and sufficiently documented - [ ] Correct, in line with design --- Makefile | 2 +- changelogs/unreleased/mypy-error-limit-fix.yml | 6 ++++++ tox.ini | 2 +- 3 files changed, 8 insertions(+), 2 deletions(-) create mode 100644 changelogs/unreleased/mypy-error-limit-fix.yml diff --git a/Makefile b/Makefile index 6ef36bb0d7..7a802b1f32 100644 --- a/Makefile +++ b/Makefile @@ -26,7 +26,7 @@ pep8: flake8 src tests tests_common .PHONY: mypy mypy-diff mypy-save -RUN_MYPY=MYPYPATH=stubs:src python -m mypy --html-report mypy -p inmanta +RUN_MYPY=MYPYPATH=stubs:src python -m mypy --soft-error-limit=-1 --html-report mypy -p inmanta mypy: $(RUN_MYPY) diff --git a/changelogs/unreleased/mypy-error-limit-fix.yml b/changelogs/unreleased/mypy-error-limit-fix.yml new file mode 100644 index 0000000000..32c80c1d96 --- /dev/null +++ b/changelogs/unreleased/mypy-error-limit-fix.yml @@ -0,0 +1,6 @@ +description: Updated Makefile to disable mypy error limit +change-type: patch +destination-branches: + - iso4 + - iso5 + - master diff --git a/tox.ini b/tox.ini index 739bfff27c..e1a7f3b88d 100644 --- a/tox.ini +++ b/tox.ini @@ -55,5 +55,5 @@ commands_pre = mkdir -p coverage whitelist_externals = */mkdir setenv = MYPYPATH=stubs:src commands = - python -m mypy --junit-xml mypy.xml --cobertura-xml-report coverage -p inmanta + python -m mypy --soft-error-limit=-1 --junit-xml mypy.xml --cobertura-xml-report coverage -p inmanta ignore_outcome = true