fix(package): Don't publish source maps #508
Merged
+12
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wooorm
approved these changes
Apr 20, 2022
fb55
added a commit
that referenced
this pull request
Apr 20, 2022
#508 didn't work as expected; this adds an `.npmignore` file that excludes all unwanted files.
Closed
jmbpwtw
pushed a commit
to jmbpwtw/parse5
that referenced
this pull request
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root
tsconfig.jsonfile asks for source maps to be generated. If we ship these with the published packages, they will point at the.tsfiles in the relative directory, which aren't shipped with the packages. This makes the source maps useless for debugging, and a source of errors otherwise.I originally wanted to adopt the approach from
entities, where I used thesourceRootfield to point to the original source files on GitHub (fb55/entities#788). Unfortunately, this doesn't work withtsc --build(microsoft/TypeScript#25613) and would require a work-around1.Footnotes
Something along the lines of defining a source root in each package's
tsconfig.json, then updating all of them to point to a specific commit in asedscript. ↩