Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple tendermint-rpc from tendermint-proto #1233

Closed
mzabaluev opened this issue Nov 16, 2022 · 0 comments · Fixed by #1234
Closed

Decouple tendermint-rpc from tendermint-proto #1233

mzabaluev opened this issue Nov 16, 2022 · 0 comments · Fixed by #1234
Labels
breaking enhancement New feature or request rpc

Comments

@mzabaluev
Copy link
Contributor

Description

After #1203 and #1090, a few direct uses of tendermint-proto remain in tendermint-rpc, so I see an opportunity to remove the direct API link in preparation to #1193. The only significant change is to replace direct use of a generated TxProto struct with a domain type. That type will also use Hash in all proper places.

Definition of "done"

tendermint-rpc no longer lists tendermint-proto in its dependencies, its public API only exposes tendermint types and functions (some of which may be re-imports of tendermint-proto).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking enhancement New feature or request rpc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant