Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tendermint-rpc: Improve Query API #1230

Closed
romac opened this issue Nov 15, 2022 · 0 comments · Fixed by #1229
Closed

tendermint-rpc: Improve Query API #1230

romac opened this issue Nov 15, 2022 · 0 comments · Fixed by #1229
Assignees
Labels
enhancement New feature or request rpc

Comments

@romac
Copy link
Member

romac commented Nov 15, 2022

Description

I would like to improve the tendermint_rpc::Query API in two ways which would be useful for Hermes:

  1. Make the event_type and conditions fields of Query public. This would allow us to introspect, modify and evaluate queries on the Hermes side, something which we find ourselves needing right now to work around a behavior of the Tendermint indexer.
  2. Add a fn key(&self) -> &str method to Condition which would return the key that this condition applies to. The use case is the same as (1), where we need to partition conditions by keys and only evaluate the relevant ones.

Definition of "done"

The two suggestions above are implemented.

@romac romac added enhancement New feature or request rpc labels Nov 15, 2022
@romac romac self-assigned this Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request rpc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant