Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-split sov-ibc and sov-ibc-transfer modules, and also separate test utils into sov-ibc-mocks #12

Closed
Farhad-Shabani opened this issue Oct 9, 2023 · 0 comments · Fixed by #14
Assignees
Labels
modules Related to ibc modules

Comments

@Farhad-Shabani
Copy link
Member

Farhad-Shabani commented Oct 9, 2023

Background

As of informalsystems/sovereign-sdk#11, sov-ibc and sov-ibc-transfer have been combined.
This decision was made because sov-ibc is implemented in a way that it couldn't function independently without sov-ibc-transfer. Additionally, not clear how a new IBC application should be plugged in without needing to hardcode things, at least not in the Ibc<C, Da> struct. Consequently, this led to confusion that these two components should coexist.

However, recent experience of working on the demo-rollup revealed:

In the context of the rollup application, each of the structs implemented ModuleInfo represents a distinct module within the Sovereign SDK system. Thus, each should essentially be plugged in, initialized, and ideally operated independently. Thus, The mentioned merge hasn't offered much in practice. Conversely, that has complicated dependency and feature management. We may want to enable a feature in one module without necessarily activating it for the entire repository.

To decouple sov-ibc and sov-ibc-transfer and clear up mentioned confusion, the issue #13 has been opened.

Proposal

Within this issue, we aim to re-split sov-ibc and sov-ibc-transfer with some adjustments from demo-rollup experience. Accordingly can go further and split up existing abstraction and implementation for tests to live in a separate sov-ibc-mocks crate.

@Farhad-Shabani Farhad-Shabani added the modules Related to ibc modules label Oct 9, 2023
@Farhad-Shabani Farhad-Shabani changed the title Re-split sov-ibc and sov-ibc-transfer modules, and also separate test utils into sov-ibc-mock Re-split sov-ibc and sov-ibc-transfer modules, and also separate test utils into sov-ibc-mocks Oct 9, 2023
@Farhad-Shabani Farhad-Shabani self-assigned this Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
modules Related to ibc modules
Projects
Status: ✅ Done
1 participant