Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICS20 module requirements #53

Open
hu55a1n1 opened this issue May 5, 2022 · 1 comment
Open

ICS20 module requirements #53

hu55a1n1 opened this issue May 5, 2022 · 1 comment

Comments

@hu55a1n1
Copy link
Member

hu55a1n1 commented May 5, 2022

We're essentially looking for answers to these questions ->

  • Is the ibc-rs ICS20 API readily usable?
    • eg. Router, app module?
  • Are we missing any gRPC endpoints?
  • What changes are required to the bank module?
  • Can we make progress here before ICS20 is delivered on ibc-rs side?
@hu55a1n1
Copy link
Member Author

hu55a1n1 commented May 5, 2022

Is the ibc-rs ICS20 API readily usable?

I think the DummyTransferModule implementation in the ibc-rs ICS20 PR gives us some confidence on the usability of the API as that is modelled in a way that is very similar to basecoin's implementation.

Are we missing any gRPC endpoints?

From my preliminary findings, it doesn't seem like we'd need any additional gRPC endpoints on basecoin's side for the ICS20 module impl. Turns out we might need some gRPC endpoints for ICS20 -> https://github.com/cosmos/ibc-go/blob/main/proto/ibc/applications/transfer/v1/query.proto. Still not clear if and where hermes uses them.

What changes are required to the bank module?

We need support for module accounts and the ability to mint and burn tokens.

Can we make progress here before ICS20 is delivered on ibc-rs side?

We could start by updating basecoin's dependencies to match those of ibc-rs and make changes to the bank and accounts facilities. But the API is expected to see major changes with the ICS20 implementation and OCap removal, so I think we it's better to wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant