Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_packet_{commitment,acknowledgement} should return error if delete_packet_{commitment,acknowledgement} called #128

Open
rnbguy opened this issue Sep 7, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@rnbguy
Copy link
Member

rnbguy commented Sep 7, 2023

Currently, get_packet_commitment returns the commitment stored at a commitment path. But this commitment may not be valid - as delete_packet_commitment may have set it to empty.

This leads to transaction failure at ibc-rs implementation, where it should have succeeded. The false failures due to get_packet_commitment at ibc-rs,

The argument for get_packet_acknowledgement and delete_packet_acknowledgement is the same. The false failure due to get_packet_acknowledgement at ibc-rs,

@rnbguy rnbguy added the bug Something isn't working label Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant