This repository was archived by the owner on Oct 29, 2024. It is now read-only.
tests: add basic type checking with mypy #756
Merged
+27
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! |
sebito91
approved these changes
Sep 10, 2019
xginn8
force-pushed
the
736-mypy-typings
branch
2 times, most recently
from
b2ba263 to
92ba134
Compare
xginn8
force-pushed
the
736-mypy-typings
branch
from
92ba134 to
c010f14
Compare
|
@aviau tests are now passing, PTAL as I'm new to |
|
LGTM! The rest should be done in other PRs, type stuff as we go. I have mypy experience so let me know if you guys have questions while typing stuff. |
aviau
approved these changes
Sep 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #736
Contributor checklist