This repository was archived by the owner on Oct 29, 2024. It is now read-only.
Adding time_precision optional option to SeriesHelper #502
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
time_precision option not currently supported in influx-db python
Changed it from required to optional
|
I hope you find time to review this once |
|
Can you please write a test? |
xginn8
reviewed
Nov 25, 2017
influxdb/helper.py
Outdated
| @@ -41,6 +41,10 @@ class Meta: | |||
| # Only applicable if autocommit is True. | |||
| autocommit = True | |||
| # If True and no bulk_size, then will set bulk_size to 1. | |||
| time_precions= "s"|"ns"|"ms"|"u" | |||
There was a problem hiding this comment.
small typo here, s/precions/precisions/
|
salut @aviau , qu'est-ce que je dois faire pour que ce changement soit appliqué dans le prochain release? :) |
|
Il faudrait commencer pas régler les tests. |
|
Closed by #719 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#501 Issue Resolution