Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linter: gosec, Rule: G104 - Audit errors not checked. Should we enable it? #12892

Closed
zak-pawel opened this issue Mar 18, 2023 · 7 comments
Closed

Linter: gosec, Rule: G104 - Audit errors not checked. Should we enable it? #12892

zak-pawel opened this issue Mar 18, 2023 · 7 comments
Labels
linter

Comments

@zak-pawel
Copy link
Collaborator

Use Case

This issue starts discussion about enabling:

Rule is mapped to CWE-703: Improper Check or Handling of Exceptional Conditions.

Expected behavior

Decision if rule should be enabled or not.

Actual behavior

For this rule no findings were found in current code.

Probably, because other linter guards checking errors. However, nothing prevents us from turning also G104 on.

Additional info

For this rule additional configuration can be provided:

      # Additional functions to ignore while checking unhandled errors.
      # Following functions always ignored:
      #   bytes.Buffer:
      #     - Write
      #     - WriteByte
      #     - WriteRune
      #     - WriteString
      #   fmt:
      #     - Print
      #     - Printf
      #     - Println
      #     - Fprint
      #     - Fprintf
      #     - Fprintln
      #   strings.Builder:
      #     - Write
      #     - WriteByte
      #     - WriteRune
      #     - WriteString
      #   io.PipeWriter:
      #     - CloseWithError
      #   hash.Hash:
      #     - Write
      #   os:
      #     - Unsetenv
      # Default: {}
      G104:
        fmt:
          - Fscanf
@zak-pawel zak-pawel added feature request Requests for new plugin and for new features to existing plugins needs design review labels Mar 18, 2023
@Hipska
Copy link
Contributor

Hipska commented Mar 21, 2023

I think this one can even replace the existing err check linter. As here we can tell to ignore for example buffer.WriteByte which is never going to return an error.

@powersj
Copy link
Contributor

powersj commented Mar 21, 2023

However, nothing prevents us from turning also G104 on.

+1

@zak-pawel zak-pawel added linter and removed feature request Requests for new plugin and for new features to existing plugins needs design review labels Mar 22, 2023
@zak-pawel
Copy link
Collaborator Author

zak-pawel commented Mar 26, 2023 •
edited

With exclude-use-default: false set in .golangci.yml following findings were found for this rule:

cmd/telegraf/main.go:161:4                                                      gosec  G104: Errors unhandled.
cmd/telegraf/main.go:163:4                                                      gosec  G104: Errors unhandled.
cmd/telegraf/main.go:165:4                                                      gosec  G104: Errors unhandled.
cmd/telegraf/main.go:167:4                                                      gosec  G104: Errors unhandled.
cmd/telegraf/main.go:172:4                                                      gosec  G104: Errors unhandled.
cmd/telegraf/main.go:179:5                                                      gosec  G104: Errors unhandled.
cmd/telegraf/main.go:184:4                                                      gosec  G104: Errors unhandled.
cmd/telegraf/main.go:191:5                                                      gosec  G104: Errors unhandled.
cmd/telegraf/main.go:204:4                                                      gosec  G104: Errors unhandled.
cmd/telegraf/main.go:360:6                                                      gosec  G104: Errors unhandled.
cmd/telegraf/printer.go:113:2                                                   gosec  G104: Errors unhandled.
cmd/telegraf/printer.go:142:5                                                   gosec  G104: Errors unhandled.
cmd/telegraf/printer.go:146:4                                                   gosec  G104: Errors unhandled.
cmd/telegraf/printer.go:163:5                                                   gosec  G104: Errors unhandled.
cmd/telegraf/printer.go:167:4                                                   gosec  G104: Errors unhandled.
cmd/telegraf/printer.go:180:5                                                   gosec  G104: Errors unhandled.
cmd/telegraf/printer.go:184:4                                                   gosec  G104: Errors unhandled.
cmd/telegraf/printer.go:197:5                                                   gosec  G104: Errors unhandled.
cmd/telegraf/printer.go:201:4                                                   gosec  G104: Errors unhandled.
cmd/telegraf/printer.go:291:2                                                   gosec  G104: Errors unhandled.
cmd/telegraf/printer.go:348:3                                                   gosec  G104: Errors unhandled.
cmd/telegraf/printer.go:352:3                                                   gosec  G104: Errors unhandled.
cmd/telegraf/printer.go:367:3                                                   gosec  G104: Errors unhandled.
cmd/telegraf/printer.go:373:3                                                   gosec  G104: Errors unhandled.
cmd/telegraf/printer.go:374:3                                                   gosec  G104: Errors unhandled.
cmd/telegraf/printer.go:377:3                                                   gosec  G104: Errors unhandled.
cmd/telegraf/printer.go:380:5                                                   gosec  G104: Errors unhandled.
cmd/telegraf/printer.go:383:4                                                   gosec  G104: Errors unhandled.
metric/metric.go:265:2                                                          gosec  G104: Errors unhandled.
metric/metric.go:266:2                                                          gosec  G104: Errors unhandled.
metric/metric.go:268:3                                                          gosec  G104: Errors unhandled.
metric/metric.go:269:3                                                          gosec  G104: Errors unhandled.
metric/metric.go:270:3                                                          gosec  G104: Errors unhandled.
metric/metric.go:271:3                                                          gosec  G104: Errors unhandled.
metric/series_grouper.go:103:2                                                  gosec  G104: Errors unhandled.
metric/series_grouper.go:90:2                                                   gosec  G104: Errors unhandled.
metric/series_grouper.go:91:2                                                   gosec  G104: Errors unhandled.
metric/series_grouper.go:94:3                                                   gosec  G104: Errors unhandled.
metric/series_grouper.go:95:3                                                   gosec  G104: Errors unhandled.
metric/series_grouper.go:96:3                                                   gosec  G104: Errors unhandled.
metric/series_grouper.go:97:3                                                   gosec  G104: Errors unhandled.
metric/series_grouper.go:99:2                                                   gosec  G104: Errors unhandled.
models/running_output_test.go:43:3                                              gosec  G104: Errors unhandled.
models/running_output_test.go:59:4                                              gosec  G104: Errors unhandled.
plugins/common/tls/config_test.go:469:6                                         gosec  G104: Errors unhandled.
plugins/inputs/amqp_consumer/amqp_consumer.go:410:4                             gosec  G104: Errors unhandled.
plugins/inputs/amqp_consumer/amqp_consumer.go:443:4                             gosec  G104: Errors unhandled.
plugins/inputs/amqp_consumer/amqp_consumer.go:449:4                             gosec  G104: Errors unhandled.
plugins/inputs/burrow/burrow_test.go:40:3                                       gosec  G104: Errors unhandled.
plugins/inputs/burrow/burrow_test.go:64:3                                       gosec  G104: Errors unhandled.
plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_mdt.go:182:4                 gosec  G104: Errors unhandled.
plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_mdt.go:213:3                 gosec  G104: Errors unhandled.
plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_mdt.go:734:3                 gosec  G104: Errors unhandled.
plugins/inputs/cloud_pubsub_push/cloud_pubsub_push.go:140:2                     gosec  G104: Errors unhandled.
plugins/inputs/cloud_pubsub_push/cloud_pubsub_push_test.go:197:5                gosec  G104: Errors unhandled.
plugins/inputs/cloudwatch_metric_streams/cloudwatch_metric_streams.go:395:3     gosec  G104: Errors unhandled.
plugins/inputs/dcos/client.go:295:3                                             gosec  G104: Errors unhandled.
plugins/inputs/diskio/diskio_linux_test.go:40:3                                 gosec  G104: Errors unhandled.
plugins/inputs/haproxy/haproxy_test.go:38:5                                     gosec  G104: Errors unhandled.
plugins/inputs/http_listener_v2/http_listener_v2.go:140:3                       gosec  G104: Errors unhandled.
plugins/inputs/http_response/http_response_test.go:102:3                        gosec  G104: Errors unhandled.
plugins/inputs/jenkins/client.go:72:3                                           gosec  G104: Errors unhandled.
plugins/inputs/jenkins/jenkins_test.go:101:2                                    gosec  G104: Errors unhandled.
plugins/inputs/jti_openconfig_telemetry/jti_openconfig_telemetry.go:77:3        gosec  G104: Errors unhandled.
plugins/inputs/jti_openconfig_telemetry/jti_openconfig_telemetry_test.go:262:3  gosec  G104: Errors unhandled.
plugins/inputs/kafka_consumer/kafka_consumer.go:207:5                           gosec  G104: Errors unhandled.
plugins/inputs/mesos/mesos.go:517:2                                             gosec  G104: Errors unhandled.
plugins/inputs/mesos/mesos_test.go:291:3                                        gosec  G104: Errors unhandled.
plugins/inputs/mesos/mesos_test.go:299:3                                        gosec  G104: Errors unhandled.
plugins/inputs/nsq_consumer/nsq_consumer_test.go:223:2                          gosec  G104: Errors unhandled.
plugins/inputs/nsq_consumer/nsq_consumer_test.go:224:2                          gosec  G104: Errors unhandled.
plugins/inputs/p4runtime/p4runtime.go:125:2                                     gosec  G104: Errors unhandled.
plugins/inputs/passenger/passenger_test.go:37:2                                 gosec  G104: Errors unhandled.
plugins/inputs/phpfpm/child.go:279:2                                            gosec  G104: Errors unhandled.
plugins/inputs/phpfpm/child.go:294:2                                            gosec  G104: Errors unhandled.
plugins/inputs/phpfpm/child.go:295:2                                            gosec  G104: Errors unhandled.
plugins/inputs/phpfpm/child.go:298:3                                            gosec  G104: Errors unhandled.
plugins/inputs/phpfpm/fcgi.go:232:3                                             gosec  G104: Errors unhandled.
plugins/inputs/postgresql/service.go:146:2                                      gosec  G104: Errors unhandled.
plugins/inputs/powerdns/powerdns_test.go:60:5                                   gosec  G104: Errors unhandled.
plugins/inputs/powerdns/powerdns_test.go:61:5                                   gosec  G104: Errors unhandled.
plugins/inputs/powerdns_recursor/powerdns_recursor_test.go:115:4                gosec  G104: Errors unhandled.
plugins/inputs/powerdns_recursor/powerdns_recursor_test.go:116:4                gosec  G104: Errors unhandled.
plugins/inputs/powerdns_recursor/powerdns_recursor_test.go:124:5                gosec  G104: Errors unhandled.
plugins/inputs/powerdns_recursor/powerdns_recursor_test.go:130:5                gosec  G104: Errors unhandled.
plugins/inputs/powerdns_recursor/powerdns_recursor_test.go:131:5                gosec  G104: Errors unhandled.
plugins/inputs/powerdns_recursor/powerdns_recursor_test.go:170:4                gosec  G104: Errors unhandled.
plugins/inputs/powerdns_recursor/powerdns_recursor_test.go:171:4                gosec  G104: Errors unhandled.
plugins/inputs/powerdns_recursor/powerdns_recursor_test.go:179:5                gosec  G104: Errors unhandled.
plugins/inputs/powerdns_recursor/powerdns_recursor_test.go:186:5                gosec  G104: Errors unhandled.
plugins/inputs/powerdns_recursor/powerdns_recursor_test.go:192:5                gosec  G104: Errors unhandled.
plugins/inputs/powerdns_recursor/powerdns_recursor_test.go:193:5                gosec  G104: Errors unhandled.
plugins/inputs/powerdns_recursor/powerdns_recursor_test.go:194:5                gosec  G104: Errors unhandled.
plugins/inputs/powerdns_recursor/powerdns_recursor_test.go:232:4                gosec  G104: Errors unhandled.
plugins/inputs/powerdns_recursor/powerdns_recursor_test.go:233:4                gosec  G104: Errors unhandled.
plugins/inputs/powerdns_recursor/powerdns_recursor_test.go:261:5                gosec  G104: Errors unhandled.
plugins/inputs/powerdns_recursor/powerdns_recursor_test.go:263:5                gosec  G104: Errors unhandled.
plugins/inputs/powerdns_recursor/powerdns_recursor_test.go:264:5                gosec  G104: Errors unhandled.
plugins/inputs/powerdns_recursor/powerdns_recursor_test.go:265:5                gosec  G104: Errors unhandled.
plugins/inputs/sflow/packetdecoder.go:255:4                                     gosec  G104: Errors unhandled.
plugins/inputs/sflow/packetdecoder.go:260:3                                     gosec  G104: Errors unhandled.
plugins/inputs/sflow/sflow.go:93:3                                              gosec  G104: Errors unhandled.
plugins/inputs/statsd/statsd.go:871:3                                           gosec  G104: Errors unhandled.
plugins/inputs/statsd/statsd.go:923:2                                           gosec  G104: Errors unhandled.
plugins/inputs/statsd/statsd.go:948:4                                           gosec  G104: Errors unhandled.
plugins/inputs/statsd/statsd.go:952:4                                           gosec  G104: Errors unhandled.
plugins/inputs/statsd/statsd.go:966:4                                           gosec  G104: Errors unhandled.
plugins/inputs/suricata/suricata.go:73:2                                        gosec  G104: Errors unhandled.
plugins/inputs/synproxy/synproxy_test.go:61:2                                   gosec  G104: Errors unhandled.
plugins/inputs/syslog/nontransparent_test.go:188:4                              gosec  G104: Errors unhandled.
plugins/inputs/syslog/nontransparent_test.go:245:4                              gosec  G104: Errors unhandled.
plugins/inputs/syslog/octetcounting_test.go:387:4                               gosec  G104: Errors unhandled.
plugins/inputs/syslog/octetcounting_test.go:444:4                               gosec  G104: Errors unhandled.
plugins/inputs/syslog/rfc3164_test.go:97:4                                      gosec  G104: Errors unhandled.
plugins/inputs/syslog/rfc5426_test.go:260:4                                     gosec  G104: Errors unhandled.
plugins/inputs/syslog/syslog.go:100:3                                           gosec  G104: Errors unhandled.
plugins/inputs/syslog/syslog.go:142:3                                           gosec  G104: Errors unhandled.
plugins/inputs/syslog/syslog.go:268:3                                           gosec  G104: Errors unhandled.
plugins/inputs/syslog/syslog.go:419:2                                           gosec  G104: Errors unhandled.
plugins/inputs/system/system.go:109:2                                           gosec  G104: Errors unhandled.
plugins/inputs/tcp_listener/tcp_listener.go:131:2                               gosec  G104: Errors unhandled.
plugins/inputs/tcp_listener/tcp_listener.go:144:3                               gosec  G104: Errors unhandled.
plugins/inputs/tcp_listener/tcp_listener.go:197:2                               gosec  G104: Errors unhandled.
plugins/inputs/udp_listener/udp_listener.go:124:2                               gosec  G104: Errors unhandled.
plugins/inputs/webhooks/webhooks.go:112:2                                       gosec  G104: Errors unhandled.
plugins/inputs/x509_cert/x509_cert_test.go:101:6                                gosec  G104: Errors unhandled.
plugins/inputs/x509_cert/x509_cert_test.go:94:6                                 gosec  G104: Errors unhandled.
plugins/inputs/zipkin/zipkin.go:123:2                                           gosec  G104: Errors unhandled.
plugins/outputs/azure_monitor/azure_monitor.go:349:2                            gosec  G104: Errors unhandled.
plugins/outputs/azure_monitor/azure_monitor.go:350:2                            gosec  G104: Errors unhandled.
plugins/outputs/azure_monitor/azure_monitor.go:356:3                            gosec  G104: Errors unhandled.
plugins/outputs/azure_monitor/azure_monitor.go:357:3                            gosec  G104: Errors unhandled.
plugins/outputs/azure_monitor/azure_monitor.go:361:2                            gosec  G104: Errors unhandled.
plugins/outputs/azure_monitor/azure_monitor.go:362:2                            gosec  G104: Errors unhandled.
plugins/outputs/azure_monitor/azure_monitor.go:556:2                            gosec  G104: Errors unhandled.
plugins/outputs/azure_monitor/azure_monitor.go:557:2                            gosec  G104: Errors unhandled.
plugins/outputs/azure_monitor/azure_monitor.go:558:2                            gosec  G104: Errors unhandled.
plugins/outputs/azure_monitor/azure_monitor.go:559:2                            gosec  G104: Errors unhandled.
plugins/outputs/datadog/datadog_test.go:41:3                                    gosec  G104: Errors unhandled.
plugins/outputs/datadog/datadog_test.go:57:3                                    gosec  G104: Errors unhandled.
plugins/outputs/influxdb_v2/influxdb_v2_test.go:99:2                            gosec  G104: Errors unhandled.
plugins/outputs/postgresql/sqltemplate/template.go:387:3                        gosec  G104: Errors unhandled.
plugins/outputs/postgresql/sqltemplate/template.go:388:3                        gosec  G104: Errors unhandled.
plugins/outputs/postgresql/table_source.go:84:2                                 gosec  G104: Errors unhandled.
plugins/outputs/postgresql/utils/utils.go:74:3                                  gosec  G104: Errors unhandled.
plugins/outputs/postgresql/utils/utils.go:75:3                                  gosec  G104: Errors unhandled.
plugins/outputs/postgresql/utils/utils.go:76:3                                  gosec  G104: Errors unhandled.
plugins/outputs/postgresql/utils/utils.go:77:3                                  gosec  G104: Errors unhandled.
plugins/outputs/riemann/riemann.go:85:3                                         gosec  G104: Errors unhandled.
plugins/outputs/riemann_legacy/riemann_legacy.go:79:3                           gosec  G104: Errors unhandled.
plugins/outputs/socket_writer/socket_writer.go:126:5                            gosec  G104: Errors unhandled.
plugins/outputs/stackdriver/stackdriver.go:117:2                                gosec  G104: Errors unhandled.
plugins/outputs/stackdriver/stackdriver.go:118:2                                gosec  G104: Errors unhandled.
plugins/outputs/stackdriver/stackdriver.go:119:2                                gosec  G104: Errors unhandled.
plugins/outputs/stackdriver/stackdriver.go:120:2                                gosec  G104: Errors unhandled.
plugins/outputs/stackdriver/stackdriver.go:122:3                                gosec  G104: Errors unhandled.
plugins/outputs/stackdriver/stackdriver.go:123:3                                gosec  G104: Errors unhandled.
plugins/outputs/stackdriver/stackdriver.go:124:3                                gosec  G104: Errors unhandled.
plugins/outputs/stackdriver/stackdriver.go:125:3                                gosec  G104: Errors unhandled.
plugins/outputs/syslog/syslog.go:126:5                                          gosec  G104: Errors unhandled.
plugins/serializers/prometheus/collection.go:90:3                               gosec  G104: Errors unhandled.
plugins/serializers/prometheus/collection.go:91:3                               gosec  G104: Errors unhandled.
plugins/serializers/prometheus/collection.go:92:3                               gosec  G104: Errors unhandled.
plugins/serializers/prometheus/collection.go:93:3                               gosec  G104: Errors unhandled.
plugins/serializers/prometheusremotewrite/prometheusremotewrite.go:321:3        gosec  G104: Errors unhandled.
plugins/serializers/prometheusremotewrite/prometheusremotewrite.go:322:3        gosec  G104: Errors unhandled.
plugins/serializers/prometheusremotewrite/prometheusremotewrite.go:323:3        gosec  G104: Errors unhandled.
plugins/serializers/prometheusremotewrite/prometheusremotewrite.go:324:3        gosec  G104: Errors unhandled.
selfstat/selfstat.go:178:2                                                      gosec  G104: Errors unhandled.
selfstat/selfstat.go:187:3                                                      gosec  G104: Errors unhandled.

After adding gosec to existing //nolint:revive and //nolint:errcheck mix of findings with outputBuffer.Write and xxx.Close() were shown:

# outputBuffer.Write():
cmd/telegraf/main.go:161:4                                                gosec  G104: Errors unhandled.
cmd/telegraf/main.go:163:4                                                gosec  G104: Errors unhandled.
cmd/telegraf/main.go:165:4                                                gosec  G104: Errors unhandled.
cmd/telegraf/main.go:167:4                                                gosec  G104: Errors unhandled.
cmd/telegraf/main.go:172:4                                                gosec  G104: Errors unhandled.
cmd/telegraf/main.go:179:5                                                gosec  G104: Errors unhandled.
cmd/telegraf/main.go:184:4                                                gosec  G104: Errors unhandled.
cmd/telegraf/main.go:191:5                                                gosec  G104: Errors unhandled.
cmd/telegraf/main.go:204:4                                                gosec  G104: Errors unhandled.
cmd/telegraf/main.go:360:6                                                gosec  G104: Errors unhandled.
cmd/telegraf/printer.go:113:2                                             gosec  G104: Errors unhandled.
cmd/telegraf/printer.go:142:5                                             gosec  G104: Errors unhandled.
cmd/telegraf/printer.go:146:4                                             gosec  G104: Errors unhandled.
cmd/telegraf/printer.go:163:5                                             gosec  G104: Errors unhandled.
cmd/telegraf/printer.go:167:4                                             gosec  G104: Errors unhandled.
cmd/telegraf/printer.go:180:5                                             gosec  G104: Errors unhandled.
cmd/telegraf/printer.go:184:4                                             gosec  G104: Errors unhandled.
cmd/telegraf/printer.go:197:5                                             gosec  G104: Errors unhandled.
cmd/telegraf/printer.go:201:4                                             gosec  G104: Errors unhandled.
cmd/telegraf/printer.go:291:2                                             gosec  G104: Errors unhandled.
cmd/telegraf/printer.go:348:3                                             gosec  G104: Errors unhandled.
cmd/telegraf/printer.go:352:3                                             gosec  G104: Errors unhandled.
cmd/telegraf/printer.go:367:3                                             gosec  G104: Errors unhandled.
cmd/telegraf/printer.go:373:3                                             gosec  G104: Errors unhandled.
cmd/telegraf/printer.go:374:3                                             gosec  G104: Errors unhandled.
cmd/telegraf/printer.go:377:3                                             gosec  G104: Errors unhandled.
cmd/telegraf/printer.go:380:5                                             gosec  G104: Errors unhandled.
cmd/telegraf/printer.go:383:4                                             gosec  G104: Errors unhandled.
# xxx.Close():
plugins/common/tls/config_test.go:469:6                                   gosec  G104: Errors unhandled.
plugins/inputs/amqp_consumer/amqp_consumer.go:410:4                       gosec  G104: Errors unhandled.
plugins/inputs/amqp_consumer/amqp_consumer.go:443:4                       gosec  G104: Errors unhandled.
plugins/inputs/amqp_consumer/amqp_consumer.go:449:4                       gosec  G104: Errors unhandled.
plugins/inputs/jti_openconfig_telemetry/jti_openconfig_telemetry.go:77:3  gosec  G104: Errors unhandled.
plugins/inputs/p4runtime/p4runtime.go:125:2                               gosec  G104: Errors unhandled.
plugins/inputs/sflow/packetdecoder.go:255:4                               gosec  G104: Errors unhandled.
plugins/inputs/sflow/packetdecoder.go:260:3                               gosec  G104: Errors unhandled.
plugins/inputs/syslog/nontransparent_test.go:188:4                        gosec  G104: Errors unhandled.
plugins/inputs/syslog/nontransparent_test.go:245:4                        gosec  G104: Errors unhandled.
plugins/inputs/syslog/octetcounting_test.go:387:4                         gosec  G104: Errors unhandled.
plugins/inputs/syslog/octetcounting_test.go:444:4                         gosec  G104: Errors unhandled.
plugins/inputs/syslog/rfc3164_test.go:97:4                                gosec  G104: Errors unhandled.
plugins/inputs/syslog/rfc5426_test.go:260:4                               gosec  G104: Errors unhandled.
plugins/inputs/x509_cert/x509_cert_test.go:94:6                           gosec  G104: Errors unhandled.
plugins/inputs/x509_cert/x509_cert_test.go:101:6                          gosec  G104: Errors unhandled.
plugins/outputs/influxdb_v2/influxdb_v2_test.go:99:2                      gosec  G104: Errors unhandled.

Currently they are excluded by default by:

# EXC0008 gosec: Duplicated errcheck checks
- (G104|G307)

@zak-pawel zak-pawel mentioned this issue Mar 26, 2023
Closed
@zak-pawel
Copy link
Collaborator Author

More info: https://securego.io/docs/rules/g104.html

@zak-pawel
Copy link
Collaborator Author

I reviewed findings and I didn't find anything which hadn't been found by errcheck.

I think this one can even replace the existing err check linter. As here we can tell to ignore for example buffer.WriteByte which is never going to return an error.

Moreover, ignoring some functions in gosec:G104 is not possible because of golangci/golangci-lint#3749
Also, is seems that revive:unhandled-error doesn't find more issues than errcheck (and it is less flexible/configurable).

To sum up:

@Hipska Hipska mentioned this issue Apr 3, 2023
Merged
@powersj
Copy link
Contributor

powersj commented Apr 3, 2023

Agreed on not doing, so does that mean we should close this issue as not in plan?

@zak-pawel
Copy link
Collaborator Author

Closing as not in plan. :)

@zak-pawel zak-pawel closed this as not planned Won't fix, can't repro, duplicate, stale Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
linter
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Hipska @powersj @zak-pawel