Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(1.10): make buckets API fully compatible #23898

Merged
merged 1 commit into from Nov 10, 2022
Merged

fix(1.10): make buckets API fully compatible #23898

merged 1 commit into from Nov 10, 2022

Conversation

vlastahajek
Copy link
Contributor

Fixes

  • Buckets endpoints have a single REST path variable, instead of two.
  • POST to /api/v2/buckets properly returns 201 and JSON object
  • PATCH to /api/v2/buckets/:dbrp doesn't rename retention policy and returns JSON object

Note for reviwers

I hesitated about naming the REST path variable. I left the previous naming :dbrp, but it could be :bucket

@davidby-influx davidby-influx self-assigned this Nov 10, 2022
davidby-influx
davidby-influx approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@davidby-influx davidby-influx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for all the corrections and error checking. Much appreciated.

@davidby-influx davidby-influx merged commit 636fbb3 into influxdata:1.10 Nov 10, 2022
davidby-influx pushed a commit that referenced this pull request Nov 10, 2022
@vlastahajek @davidby-influx
fix: :db/:rp -> :dbrp, fixed create bucket, update bucket (#23898)
52267d3 
Fix URL processing for V2 buckets API, add error checking.

(cherry picked from commit 636fbb3)
davidby-influx added a commit that referenced this pull request Nov 11, 2022
@davidby-influx @vlastahajek
fix: :db/:rp -> :dbrp, fixed create bucket, update bucket (#23898) (#…
be9a3d4 
…23900)

Fix URL processing for V2 buckets API, add error checking.

(cherry picked from commit 636fbb3)

Co-authored-by: Vlasta Hajek <vlastimil.hajek@bonitoo.io>
@vlastahajek vlastahajek mentioned this pull request Nov 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidby-influx davidby-influx davidby-influx approved these changes

Assignees

@davidby-influx davidby-influx

Labels
1.x area/api area/meta service kind/bug team/edge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vlastahajek @davidby-influx