Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update SizedPlot to use onClick instead on mouseUp for singleClick interactions #514

Open
ChitlangeSahas opened this issue Mar 25, 2021 · 0 comments · May be fixed by #515
Open

update SizedPlot to use onClick instead on mouseUp for singleClick interactions #514

ChitlangeSahas opened this issue Mar 25, 2021 · 0 comments · May be fixed by #515
Assignees
@ChitlangeSahas

Comments

@ChitlangeSahas
Copy link
Contributor

A side effect of having mouseUp to handle the single-click behavior in SizedPlot was the launching of the annotation-create overlay when zooming into the map. This makes sense why, when zooming, we click on the graph, drag it and release the mouse. This triggered the mouseUp.

Fix: use onClick instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChitlangeSahas ChitlangeSahas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: using onClick instead of mouseUp in SizedPlot.tsx influxdata/giraffe
1 participant
@ChitlangeSahas