Skip to content
This repository has been archived by the owner on Dec 9, 2023. It is now read-only.

No longer works on Flipper 0.115.0 #77

Open
chungweileong94 opened this issue Oct 19, 2021 · 7 comments · May be fixed by #79
Open

No longer works on Flipper 0.115.0 #77

chungweileong94 opened this issue Oct 19, 2021 · 7 comments · May be fixed by #79

Comments

@chungweileong94
Copy link

For some reason, nothing works in the latest Flipper

It does log an error,

Failed to process event for plugin flipper-plugin-reactotron TypeError: Cannot assign to read only property 'path' of object '#<Object>'
@alexstanbury
Copy link

alexstanbury commented Nov 8, 2021

Same issue here (using 0.117.0), here's a full stack trace from the logs:

Failed to process event for plugin flipper-plugin-reactotron TypeError: Cannot assign to read only property 'important' of object '#<Object>'
    at t (/Users/alexstanbury/.flipper/installed-plugins/flipper-plugin-reactotron/1.1.0/dist/bundle.js:4618:53)

    at repairSerialization (/Users/alexstanbury/.flipper/installed-plugins/flipper-plugin-reactotron/1.1.0/dist/bundle.js:4622:39)

    at Function.persistedStateReducer (/Users/alexstanbury/.flipper/installed-plugins/flipper-plugin-reactotron/1.1.0/dist/bundle.js:821:74)

    at EventEmitter.<anonymous> (file:///Applications/Flipper.app/Contents/Resources/app.asar/bundle.js:5915:1349)

    at file:///Applications/Flipper.app/Contents/Resources/app.asar/bundle.js:1151:230

    at Wj (file:///Applications/Flipper.app/Contents/Resources/app.asar/bundle.js:90:98407)

    at EventEmitter.<anonymous> (file:///Applications/Flipper.app/Contents/Resources/app.asar/bundle.js:1151:219)

    at EventEmitter.emit (events.js:315:20)

    at file:///Applications/Flipper.app/Contents/Resources/app.asar/bundle.js:1554:2100

    at Array.forEach (<anonymous>)

    at SandyPluginInstance.receiveMessages (file:///Applications/Flipper.app/Contents/Resources/app.asar/bundle.js:1554:1975)

    at processMessagesImmediately (file:///Applications/Flipper.app/Contents/Resources/app.asar/bundle.js:4224:349)

    at processMessagesLater (file:///Applications/Flipper.app/Contents/Resources/app.asar/bundle.js:4224:711)

    at file:///Applications/Flipper.app/Contents/Resources/app.asar/bundle.js:4222:1402

    at Wj (file:///Applications/Flipper.app/Contents/Resources/app.asar/bundle.js:90:98407)

    at Client.flushMessageBuffer (file:///Applications/Flipper.app/Contents/Resources/app.asar/bundle.js:4222:1335)```

@chungweileong94
Copy link
Author

chungweileong94 commented Nov 8, 2021

@alexstanbury I actually have a temporary fix for this, but you might need to dig into the bundle JS code and apply the changes.

Just to save you some time, I will attach the modified bundle JS😉.

Just unzip it and put it under ~/.flipper/installed-plugins/flipper-plugin-reactotron/1.1.0/dist/bundle.js
bundle.js.zip (btw Github don't allow me to upload JS file, that's why I zip it)

@chungweileong94
Copy link
Author

I'm curious if this project is still actively maintained? As the plugin is basically unusable.

@chungweileong94
Copy link
Author

@alexstanbury I actually have a temporary fix for this, but you might need to dig into the bundle JS code and apply the changes.

Just to save you some time, I will attach the modified bundle JS😉.

Just unzip it and put it under ~/.flipper/installed-plugins/flipper-plugin-reactotron/1.1.0/dist/bundle.js bundle.js.zip (btw Github don't allow me to upload JS file, that's why I zip it)

Instead of modifying the bundle code, I applied the workaround fix and repackage on my fork.
https://github.com/chungweileong94/flipper-plugin-reactotron/releases/tag/v1.1.0-custom-fix

@alexstanbury
Copy link

Thanks, it's working for me now. Hopefully this will get fixed properly!

@chakrihacker chakrihacker linked a pull request Apr 30, 2022 that will close this issue
@alessioemireni
Copy link

+1

@noumantahir
Copy link

@alexstanbury I actually have a temporary fix for this, but you might need to dig into the bundle JS code and apply the changes.
Just to save you some time, I will attach the modified bundle JSwink.
Just unzip it and put it under ~/.flipper/installed-plugins/flipper-plugin-reactotron/1.1.0/dist/bundle.js bundle.js.zip (btw Github don't allow me to upload JS file, that's why I zip it)

Instead of modifying the bundle code, I applied the workaround fix and repackage on my fork. https://github.com/chungweileong94/flipper-plugin-reactotron/releases/tag/v1.1.0-custom-fix

worked like a charm. Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants