Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mutator: AssignCoalesce. Upgrade PHPParser to 4.2.1 #641

Merged
merged 3 commits into from Feb 18, 2019
Merged

Mutator: AssignCoalesce. Upgrade PHPParser to 4.2.1 #641

merged 3 commits into from Feb 18, 2019

Conversation

maks-rafalko
Copy link
Member

This PR:

See https://wiki.php.net/rfc/null_coalesce_equal_operator

Produces the following mutation:

- $this->request->data['comments']['user_id'] ??= 'value';
+ $this->request->data['comments']['user_id'] = 'value';

@maks-rafalko maks-rafalko added this to the 0.13.0 milestone Feb 17, 2019
@maks-rafalko maks-rafalko mentioned this pull request Feb 17, 2019
Merged
localheinz
localheinz previously approved these changes Feb 17, 2019
View reviewed changes
Copy link
Member

@localheinz localheinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

composer.json Outdated Show resolved Hide resolved
sanmai
sanmai previously approved these changes Feb 18, 2019
View reviewed changes
@maks-rafalko
Copy link
Member Author

Thank you @sanmai, @localheinz and @BackEndTea

@maks-rafalko maks-rafalko merged commit 5f162ef into master Feb 18, 2019
@maks-rafalko maks-rafalko deleted the null-coalesce-mutator branch February 18, 2019 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BackEndTea BackEndTea BackEndTea left review comments

@sanmai sanmai sanmai left review comments

@localheinz localheinz localheinz left review comments

Assignees
No one assigned
Labels
Mutator
Projects
None yet
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@maks-rafalko @sanmai @localheinz @BackEndTea