Enhancement: Implement UnwrapArrayUintersectAssoc mutator #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46 tasks
|
|
||
| protected function getParameterIndexes(Node $node): \Generator | ||
| { | ||
| yield 0; |
There was a problem hiding this comment.
Shouldn't it be
yield from \array_slice(
array_keys($node->args),
0,
\count($node->args) - 1
);as in array_intersect_uassoc? https://github.com/infection/infection/pull/591/files#diff-476671cc348930680a7c09fe701c7ffaR52
There was a problem hiding this comment.
👍
I'm not sure anymore about some of the other mutators, maybe we should adjust them as well?
There was a problem hiding this comment.
Do you have any particular mutator in mind?
There was a problem hiding this comment.
I’ll take a closer look later!
localheinz
force-pushed
the
feature/unwrap-array-uintersect-assoc
branch
from
e346f74
to
589da0b
Compare
|
Thank you, @borNfreee! |
This was referenced Feb 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
UnwrapArrayUintersectAssocmutatorRelated to #514.
💁♂️ Follows the example in #513.