New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade PHPUnit from ^6.5 to ^7.5 and all dependencies, including root differ #627
Conversation
…t sebastian/diff Run tests in a random order by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming CI doesn't report anything, 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like --min-msi
needs to be adjusted?
See https://travis-ci.org/infection/infection/jobs/492324430#L1117-L1118:
[ERROR] The minimum required MSI percentage should be 90%, but actual is 78%.
Improve your tests!
that's almost impossible in this case, because Infection is run with empty This is because no PHP source files were modified from It means that to achieve 90%, I need to do it for the whole project ;) Not feasible indeed. The goal of this target was to target 90% for the changed files, it just does not work properly with empty filter. |
misread your comment. Ok - the target MSI for changed files is ok to be 90% (original But it shouldn't be 90% when the |
Created #631 for MSI issue. Thank you. |
This PR:
PHPUnit
from^6.5
to^7.5
sebastian/diff
to^3.0
(see composer.lock). This returns back diffs with a context lines (lines before and after a modified one 🎉)Why not PHPUnit 8.0?
It requires PHP ^7.2 while we support 7.1 yet.
Next steps
pcov
--dump-xdebug-filter
(see https://thephp.cc/news/2019/01/faster-code-coverage)Had to upgrade dependencies of one of the e2e test because of fatal error: