Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test against php 7.4 #625

Merged
merged 1 commit into from Feb 11, 2019
Merged

Test against php 7.4 #625

merged 1 commit into from Feb 11, 2019

Conversation

BackEndTea
Copy link
Member

@BackEndTea BackEndTea commented Feb 11, 2019 •
edited

This PR:

  • Runs tests on php 7.4

Master is now PHP 8.0, and we also want to test against php 7.4.

PHPDBG is used because xdebug doesn't yet support the newer versions as far as i know.

Sources:

@BackEndTea
Test against php 7.4
ee0e151 
Master is PHP 8.0 until its release
maks-rafalko
maks-rafalko approved these changes Feb 11, 2019
View reviewed changes
Copy link
Member

@maks-rafalko maks-rafalko left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@maks-rafalko maks-rafalko merged commit 92c66b9 into master Feb 11, 2019
@maks-rafalko maks-rafalko deleted the travis-test-74 branch February 11, 2019 17:41
@BackEndTea
Copy link
Member Author

Thank you @borNfreee @sanmai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanmai sanmai sanmai approved these changes

@maks-rafalko maks-rafalko maks-rafalko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BackEndTea @sanmai @maks-rafalko